Repository navigation
Conversation
make pot only searched scripts/ for the Python messages of tools and lib/ for library messages, so the messages of the temporal tools and of the grass Python package (python/grass) were in no template and could not be translated. The temporal tools give 106 new messages for grassmods and the grass package 429 for grasslibs, the first domain the Python _() looks in. Also search gui/scripts, whose tools are installed like other script tools. Developed with assistance from Claude (Anthropic).
The d.rast3d and d.wms wrappers in gui/scripts have no _() messages, so searching them added nothing. The messages d.wms shows come from the r.in.wms drivers, which are already collected from scripts/r.in.wms. Add gui/scripts to MOD_PYFILES again when one of these scripts gets its own _() message, for example an error when d.wms is run outside the GUI renderer, which sets GRASS_REGION and GRASS_RENDER_FILE. Developed with assistance from Claude (Anthropic).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make potnow also searches:../temporalfor Python tool messages (grassmods),../python/grassfor library messages (grasslibs, the first domain the Python_()looks in).The templates are not regenerated here; the weekly workflow does that after building.
Motivation and context
MOD_PYFILESonly searched../scriptsandLIB_POTFILESonly../lib, so the_()messages of the temporal tools and of thegrassPython package were in no template and could not be translated.gui/scripts(d.rast3d, d.wms) is not searched: these wrappers have no_()messages, and the messages d.wms shows come from the r.in.wms drivers, already collected fromscripts/r.in.wms. It needs to be added toMOD_PYFILESwhen one of them gets its own_()message, for example an error when d.wms is run outside the GUI renderer, which setsGRASS_REGIONandGRASS_RENDER_FILE.How has this been tested?
Ran the
xgettextcommands ofmake potwith the old and new file lists and compared:python/grass, none removed.Types of changes
functionality to not work as before)
Checklist
pre-defined prefixes
of this project.
Prepared with assistance from Claude (Anthropic).