Repository navigation
Conversation
echoix
changed the title
echoix
changed the title
echoix
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fobj = open(fXML) | ||
| try: | ||
| tree = ET.fromstring(fo.read()) | ||
| tree = ET.fromstring(fobj.read()) |
There was a problem hiding this comment.
This alert is pre-existing: ET.fromstring on this line is unchanged. The PR only renamed fo to fobj, so the line shows up in the diff. Not changing it here.
Generated by Claude Code
e8444fc to
cdc1d3c
Compare
Fix typos in comments and docstrings and rename misspelled local variables, attributes and parameters.
Fix misspelled words in comments, docstrings, error messages and test code, and rename misspelled local variables. Abbreviated option names and deliberate fixtures are marked for codespell instead of changed.
Remove the Python and TeX types from the codespell exclusions in pre-commit, add the legitimate identifiers and words that codespell flags to the ignore list, and skip the vendored PLY and ctypesgen code. Typo fixes in the rest of this branch were prepared with an AI coding assistant.
cdc1d3c to
06b77cd
Compare
|
The failing check on head Generated by Claude Code |
|
|
||
|
|
||
| def create_time_suffix(mapp, end: bool = False) -> str: | ||
| def create_time_suffix(map_name, end: bool = False) -> str: |
There was a problem hiding this comment.
Is this changing part of the public api? Is there other usages that use keyword arguments? Also take a look at grass addons.
There was a problem hiding this comment.
Yes, it is public: create_time_suffix is exported in grass.temporal.__all__. All callers in core and in grass-addons pass the argument positionally, but renaming the parameter would still break any mapp= keyword caller. map_name was also wrong, since the argument is a map dataset object, not a name. I reverted the rename and added mapp to the codespell ignore list (bba489d).
Generated by Claude Code
- goodness.tex: Use "In this implementation", matching the
surrounding text.
- grass.temporal: Keep the mapp parameter name of the public
create_time_suffix() so keyword callers keep working, and add it to
the codespell ignore list. The value is a map dataset object, so
map_name was also misleading.
- r.grow test: Rename the variables of test_shrink_null consistently,
which also removes the shrined typo.
- v.report: Name the flag has_table, since it tells whether the layer
has an attribute table linked.
- g.md2man, g.html2man: Use a lowercase word in the codespell:ignore
comments. Codespell only matches lowercase words there, and the
"ignore:" form silenced the whole line.
- Fix adjacent typos left in the edited lines ("an many", "is stayed")
and use names that pair with their counterparts (denominator,
name_template).
…OSGeo#8054) * CI: Install wxPython and optional dependencies in the update-i18n job Install wxPython (python3-wxgtk4.0) and the optional dependencies of the tools listed in the menus (cairo, fftw, freetype, geos, libsvm, netcdf, opengl, postgres), and configure with the matching flags. AI was used to carry out the trivial work, following the author's implementation choices. * CI: Pin periodic_update.yml runner to ubuntu-24.04
locale: Update translation files Co-authored-by: echoix <27212526+echoix@users.noreply.github.com>
The sett variable read in the point and selection style layout loops was never used, so drop it together with the merged settings dict it was read from.
Description
Fix the typos codespell reports in Python and TeX files, and enable codespell for those file types in pre-commit.
_()) strings are changed, and the publiccreate_time_suffix(mapp, ...)signature is kept.Motivation and context
Typos in Python and TeX files were not caught by pre-commit.
How has this been tested?
pre-commit run --all-filespasses for codespell, ruff and flake8.Types of changes
Checklist
The typo fixes were prepared with an AI coding assistant.