Repository navigation
Conversation
The test computed both levenshtein_distance results but did not assert them, so it passed regardless of the value. Add the missing asserts. The change was found and fixed with AI assistance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_levenshtein_distance_empty_textcomputed bothToolFunctionResolver.levenshtein_distanceresults but never asserted them, so the test passed regardless of the value. This PR adds the missingassertstatements. The expected values (3 for an empty string against a 3-character string, in both argument orders) match the function, which I checked against a reference Levenshtein implementation.Motivation and context
Found by ruff's B015 (pointless comparison) check.
How has this been tested?
Ran
pytest python/grass/tools/tests/grass_tools_tool_function_wrap_test.py -k levenshtein: 1 passed. Ruff check and ruff format pass.Types of changes
Checklist
Generated by Claude Code