Repository navigation
Conversation
In set_region_from_rast() and set_region(), the bare raise after fatal() can never run: grass.script.fatal() either raises ScriptError or calls sys.exit(), so it never returns. A bare raise outside an except block would also be a RuntimeError, which is never reached. Remove both lines. The change was found and fixed with AI assistance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
set_region_from_rast()andset_region()inpygrass/raster/abstract.pyhave a bareraiseright afterfatal(...).grass.script.fatal()always raisesScriptErroror callssys.exit(), so the bareraisenever runs. Outside anexceptblock it would also be aRuntimeError. This PR removes the two unreachable lines. Behavior is unchanged.Motivation and context
Found by ruff's PLE0704 (bare raise outside exception handler) check.
How has this been tested?
Confirmed by reading
grass.script.core.fatal, which always raises or exits. Ruff check and ruff format pass on the file. The module importsgrass.lib, which needs a built GRASS, so I did not run the open-map code path.Types of changes
Checklist
Generated by Claude Code