Skip to content

CQ: Enable pylint checks that have no findings - #736

Open
echoix wants to merge 4 commits into
mainfrom
pylint-enable-unused-rules
Open

echoix wants to merge 4 commits into
mainfrom
pylint-enable-unused-rules

Conversation

@echoix

@echoix echoix commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Description

Remove the following messages from the GRASS pylint disable list in pyproject.toml, and remove a duplicate W0621 entry:

  • Commit 1: duplicate W0621 entry removed.
  • Commit 2: W0133, W0707, W0614, W4901, R0901 enabled. Full local run had no findings.
  • Commit 3: E0633, E1123, E1124, E1133, W0632, W4902 enabled. These depend on inference, so no findings locally without the GRASS runtime installed; CI is the check for this commit.
  • Commit 4: W4902 disabled again. CI reports deprecated-method on ten open() calls that the local run does not reproduce, so the rule stays disabled until the difference is understood.

No code changes.

Motivation and context

The pylint configuration was ported with a long list of disabled messages. These rules have no findings in the repository, so enabling them prevents new violations at no cost. Other disabled rules with findings are left for follow-up.

How has this been tested?

  • Ran pylint 4.1.2 (the version pinned in the Python Code Quality workflow) over the whole repository with the new pyproject.toml, matching the CI command: exit 0, no messages.
  • The CI workflow runs the same command with the GRASS runtime installed, which can change inference-based results. The CI run on the current head passed.

Types of changes

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • PR title provides summary of the changes and starts with one of the pre-defined prefixes
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

The redefined-outer-name message was listed twice in the GRASS disable list. Keep a single entry.
Remove W0133, W0707, W0614, W4901 and R0901 from the GRASS disable list. A full run of pylint 4.1.2 over the repository reports no findings for these, so enabling them does not require code changes.
Remove E0633, E1123, E1124, E1133, W0632 and W4902 from the GRASS disable list. No findings in a local run without the GRASS runtime installed; these rely on inference that can differ in CI, so verify the CI result before relying on them.
CI reports deprecated-method (W4902) on ten open() calls in the GUI, grass.grassdb and scripts/g.extension. A local run with the same pylint version and config does not reproduce these hits, so keep the rule disabled until the difference is understood.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants