Repository navigation
Conversation
The redefined-outer-name message was listed twice in the GRASS disable list. Keep a single entry.
Remove W0133, W0707, W0614, W4901 and R0901 from the GRASS disable list. A full run of pylint 4.1.2 over the repository reports no findings for these, so enabling them does not require code changes.
Remove E0633, E1123, E1124, E1133, W0632 and W4902 from the GRASS disable list. No findings in a local run without the GRASS runtime installed; these rely on inference that can differ in CI, so verify the CI result before relying on them.
CI reports deprecated-method (W4902) on ten open() calls in the GUI, grass.grassdb and scripts/g.extension. A local run with the same pylint version and config does not reproduce these hits, so keep the rule disabled until the difference is understood.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the following messages from the GRASS pylint disable list in
pyproject.toml, and remove a duplicateW0621entry:W0621entry removed.W0133,W0707,W0614,W4901,R0901enabled. Full local run had no findings.E0633,E1123,E1124,E1133,W0632,W4902enabled. These depend on inference, so no findings locally without the GRASS runtime installed; CI is the check for this commit.W4902disabled again. CI reportsdeprecated-methodon tenopen()calls that the local run does not reproduce, so the rule stays disabled until the difference is understood.No code changes.
Motivation and context
The pylint configuration was ported with a long list of disabled messages. These rules have no findings in the repository, so enabling them prevents new violations at no cost. Other disabled rules with findings are left for follow-up.
How has this been tested?
pyproject.toml, matching the CI command: exit 0, no messages.Types of changes
Checklist