Repository navigation
Conversation
ninsbl
approved these changes
Oct 11, 2026
Owner
Author
|
It's not opened on osgeo/grass yet, I was testing it here |
|
Did not realise this was against your fork. I will approve in the GRASS repo as soon as you open there and tests pass here... |
Owner
Author
|
It's so fun to use AI to do the boring work that is just missing time to do; or to finish work that was started but never finished. |
…dows pathlib uses os.sep in the string form of paths, so the tests that compare against forward-slash strings failed on Windows. Compare against the same strings with os.sep and drop the xfail_windows markers from the four tests which this fixes. Extracted from OSGeo#2616 by Stefan Blumentrath.
echoix
force-pushed
the
grassdb-test-manage-windows-os-sep
branch
from
October 11, 2026 11:47
8e0fc52 to
11a2a2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pathlibusesos.sepin the string form of paths, so four tests inpython/grass/grassdb/testsuite/test_manage.pyfailed on Windows when comparing against forward-slash strings. The expected values now useos.sep, and the@xfail_windowsmarkers on these four tests are removed.Extracted from OSGeo#2616 (originally by @ninsbl, authorship kept in the commit). Part of the checklist in that PR's description.
Motivation and context
Removes four expected failures on Windows by fixing the tests rather than marking them.
How has this been tested?
ruff checkandruff format --checkpass. On Linux/macOS,os.sepis/, so the assertions are unchanged. The fix needs a run on Windows (gunittest on OSGeo4W) to confirm that the four tests pass.Types of changes
Checklist
pre-defined prefixes
of this project.
Generated by Claude Code