Repository navigation
Conversation
The doctest wrapper in pygrass/modules/grid/testsuite loaded no tests. It was a copy of the one for shortcuts with the only addTests() call commented out. The doctests of the grid module were run by the wrapper in pygrass/modules/testsuite instead. Load the doctests of grid, patch and split in the grid wrapper. The wrapper in pygrass/modules/testsuite then loaded only the interface package, which has no doctests (its modules are loaded by the wrapper in pygrass/modules/interface/testsuite), so remove it. The changes were developed with the help of an AI assistant (Claude).
echoix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on #744 (this PR is based on that branch, so only the last commit is new).
The doctest wrapper in
pygrass/modules/grid/testsuiteloaded no tests: it was a copy of the one forshortcutswith its onlyaddTests()call commented out. The doctests of the grid module were run by the wrapper inpygrass/modules/testsuiteinstead.grid,patchandsplitin the grid wrapper.pygrass/modules/testsuite. After the move it loaded only theinterfacepackage, which has no doctests (its modules are loaded bypygrass/modules/interface/testsuite), and remove its entry in the ruff per-file ignores.Motivation and context
A wrapper that reports
Ran 0 testsand passes hides that nothing is tested, and the grid doctests were in an unrelated place.How has this been tested?
python3 -m grass.gunittest.main --location-type nc --config .gunittest.cfgwithnc_spm_full_v2beta1onpython/grass/pygrass/modules: all 6 files pass, and the grid wrapper now runs the same 6 doctests as before.ruff checkandruff format --checkpass.Types of changes
functionality to not work as before)
Checklist
pre-defined prefixes
of this project.
The changes were developed with the help of an AI assistant (Claude).
Generated by Claude Code