Skip to content

testkit-fixes - #65

Merged
stbischof merged 3 commits into
eclipse-daanse:mainfrom
dbulahov:main201026
Oct 20, 2026
Merged

stbischof merged 3 commits into
eclipse-daanse:mainfrom
dbulahov:main201026

Conversation

@dbulahov

Copy link
Copy Markdown
Contributor

What does this PR do?

Testkit fixes for failures :

  • oracle: 400 processes instead of the image's 200, so a pool per class is no longer refused with ORA-12516; test connections give up after 15 minutes instead of hanging in a socket read. New ManyShortConnectionsAreNotRefusedTest.
  • mssql: test databases use the UTF-8 collation Latin1_General_100_CI_AS_SC_UTF8, so non-Latin test data no longer arrives as ?.
  • derby: one in-memory database per isolation key, as H2 does, so fixtures no longer see each other's tables.

The image's processes=200 leave about 118 for connections; a suite that opens and closes a pool per class makes the
listener refuse with ORA-12516 although the instance is far from full. The provider sets processes after the container
starts and restarts the instance (daanse.testkit.oracle.processes, 0 keeps the image's setting). 1000 processes left
16 MB of the image's SGA free in a full run; 400 is the idle background plus room for the burst. A connection the
server no longer served kept a run waiting two hours in a socket read; test connections give up after 15 minutes
(daanse.testkit.oracle.readTimeoutMillis, 0 waits forever).

Signed-off-by: dbulahov <bulahovdenis@gmail.com>
Under the server default SQL_Latin1_General_CP1_CI_AS a VARCHAR keeps code page 1252, and test data in other scripts
arrived as '?'. Latin1_General_100_CI_AS_SC_UTF8 keeps case and accent insensitivity.

Signed-off-by: dbulahov <bulahovdenis@gmail.com>
// a UTF-8 collation: under the server's default (SQL_Latin1_General_CP1_CI_AS) a VARCHAR keeps code page
// 1252 only, and test data in other scripts arrived as '?' (Cyrillic in the Member Identifier tutorial,
// database run 19./20.10.). Still case- and accent-insensitive like the default.
st.execute("IF DB_ID('" + dbName + "') IS NULL CREATE DATABASE [" + dbName + "] COLLATE " + COLLATION);
@dbulahov
dbulahov force-pushed the main201026 branch 3 times, most recently from ff4fbd1 to d92cd2e Compare October 20, 2026 18:32
Every key shared one database, and the second fixture found the tables of the first. Each key gets its own
memory:daanse-<UUID> database, as H2 does.
Signed-off-by: dbulahov <bulahovdenis@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@stbischof
stbischof merged commit 756af06 into eclipse-daanse:main Oct 20, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants