Repository navigation
perf(ccc): do not build the CongoCC tree - #52
Merged
Merged
Conversation
The ccc grammar builds the record model in its actions and never reads the CongoCC parse tree, which was built and discarded on every parse (about a sixth of the CPU, a third of the allocations). TREE_BUILDING_ENABLED = false leaves it out; the wrapper drops its trace-level tree dump and reads error positions from Token directly. FoodMart corpus, 257 statements, JDK 25, old and new in both orders: warm 63-72 -> 36-41 us per statement, first statement in a fresh JVM 125-127 -> 103-110 ms, first pass 1249-1303 -> 905-957 us per statement. TCK green (213 tests), the model of every corpus statement is unchanged. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ccc grammar builds the record model in its actions and never reads the CongoCC parse tree, which was built and discarded on every parse (about a sixth of the CPU and a third of the allocations).
TREE_BUILDING_ENABLED = falseleaves it out. The wrapper drops its trace-level tree dump and reads error positions fromTokendirectly.Measured on the FoodMart corpus (257 statements), JDK 25, old and new in both orders: