Repository navigation
dialect: a DATE and a TIMESTAMP column are read with their own getters - #74
Merged
Merged
Conversation
stbischof
force-pushed
the
pr/date-timestamp-type-map
branch
from
October 31, 2026 14:57
0d1abbf to
b9899d2
Compare
The default type map gives Types.DATE the column type DATE and Types.TIMESTAMP the column type TIMESTAMP. Oracle reports its DATE as TIMESTAMP, since it carries a time of day, and keeps it so: read as a date it would lose the time, and its members and segment predicates would miss the rows. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
stbischof
force-pushed
the
pr/date-timestamp-type-map
branch
from
October 31, 2026 15:04
b9899d2 to
ec1ac66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types.DATEthe column typeDATEandTypes.TIMESTAMPthe column typeTIMESTAMP, so such a column is read withgetDate/getTimestampinstead ofgetObject.DATEasTIMESTAMP, since it carries a time of day, and keeps it so: read as a date it would lose the time, and its members and segment predicates would miss the rows.