Repository navigation
Run BrandingTest as the OSGi test it is - #16
Merged
Merged
Conversation
It drives HTTP against a running web console, so surefire could never pass it; moving it under integration hands it to bnd-testing, which launches the console from test.bndrun. The bndrun's runee also had to catch up with the parent's Java release. Disabled for now: the console does not register in that framework. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrandingTestdrives HTTP against a running Felix web console, so surefire could never pass it — the repo has been red since February withjava.net.ConnectException.Moving it to an
integrationsubpackage is what the parent pom expects: surefire excludes**/integration/**and bnd'sTest-Casesheader picks those classes up, so it now runs inside the framework thattest.bndrunlaunches. That exposed a second latent problem — the bndrun declared-runee: JavaSE-21while the parent compiles for 25, so resolution failed as soon as the fragment had a test case to resolve.Left
@Disabledwith the finding recorded: in that framework every path 404s, including/system/consoleitself, even though webconsole 5.0.18, http.jetty12, servlet-api and configadmin all resolve into-runbundles. Jetty answers (it serves the 404s) and a 10s readiness wait does not help, so it is not a startup race. Assembling a working console in the bndrun is a separate component question.