GLSP-1682: Align repository with glsp-core and modernize the client toolchain - #148
Merged
Merged
Conversation
- Replace the generated "Repository Guidelines" in AGENTS.md with the minimal bullet form the other repos use: only what is not derivable from the code, such as the client/server split and the copy:client step the example plugin depends on. CLAUDE.md now only imports it, and client/CLAUDE.md is dropped, its @AGENTS.md import pointed at a file that never existed - Extend the /fix skill to both halves: the client workspace and the Maven build with the checkstyle summary, mirroring the CI split that collects violations instead of aborting at validate - Mirror both skills under .agents for agents that do not read .claude and stop the changelog skill from being invoked implicitly - Point README and CONTRIBUTING at glsp-core instead of glsp-client - Exclude .claude/** and .agents/** from the CI triggers and tidy the agent entries in .gitignore Part of: eclipse-glsp/glsp#1682
The client tooling is provided by @eclipse-glsp/dev, which now comes from glsp-core and ships oxlint and oxfmt instead of ESLint and Prettier. @eclipse-glsp/eslint-config stopped at 2.9.0-next.1 and is no longer part of the meta package, so the ESLint setup would freeze where it is. - Move the workspace to Node 24 and pnpm 12, and with it the workflows to node-version 24 and pnpm/action-setup v6.1.0, which is the first version that can install pnpm 12 - Replace ESLint and Prettier with oxlint and oxfmt: add the two configs, drop .prettierrc, eslint.config.mjs, tsconfig.eslint.json and the per-package lint scripts. oxlint type-checks the same program it lints, so `pnpm lint` no longer needs a prior build, and the CI lint job emits annotations and a summary table through lint-report.mjs instead of routing the ESLint JSON through a third-party converter - Update TypeScript to 7.0 and pin the GLSP dependencies to the current next versions, matching the other integration repositories - Point the editor configuration at the oxc extension and the TypeScript native preview, since the TypeScript 7 package ships no tsserver Part of: eclipse-glsp/glsp#1682
`.vscode/**` is anchored at the repository root, so the client workspace keeps its own `client/.vscode` out of reach of the filter and every change to it starts a full client and server build. Part of: eclipse-glsp/glsp#1682
tortmayr
force-pushed
the
glsp-core-alignment
branch
from
September 17, 2026 12:34
e15162f to
64fb84f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Aligns this repository with
glsp-core: the agent setup the other repositoriesalready share, and the client toolchain that
@eclipse-glsp/devnow provides.@eclipse-glsp/eslint-configstopped at2.9.0-next.1and is no longer part of themeta package, so the ESLint/Prettier setup would otherwise freeze where it is.
Agent setup
AGENTS.mdwith the minimalbullet form the other repos use: only what is not derivable from the code, such as
the client/server split and the
copy:clientstep the example plugin depends on.CLAUDE.mdonly imports it, andclient/CLAUDE.mdis dropped — its@AGENTS.mdimport pointed at a file that never existed
/fixskill to both halves: the client workspace and the Maven buildwith the checkstyle summary, mirroring the CI split that collects violations
instead of aborting at
validate.agentsfor agents that do not read.claude, and stopthe changelog skill from being invoked implicitly
READMEandCONTRIBUTINGatglsp-coreinstead ofglsp-clientClient toolchain
node-version: 24andpnpm/action-setupv6.1.0 (first version that can install pnpm 12).prettierrc,eslint.config.mjs,tsconfig.eslint.jsonand the per-packagelintscripts aregone. oxlint type-checks the same program it lints, so
pnpm lintneeds no priorbuild, and the CI lint job emits inline annotations plus a summary table through
lint-report.mjsinstead of routing ESLint JSON through a third-party converternextversions asin the theia and vscode repositories
since the TypeScript 7 package ships no tsserver
Also:
.claude/**and.agents/**from the CI triggers and tidy the agententries in
.gitignorePart of: eclipse-glsp/glsp#1682
How to test
pnpm check:allpasses end to end (build, lint, format check, and the header check across the TS and Java sources)pnpm copy:clientstill copies the bundle into the workflow editor pluginCI (Server)covers itFollow-ups
nextpins are snapshots (2.9.0-next.3/2.9.0-next.4);pnpm upgrade:nextrefreshes them before the next release.glsp-coreadditionally carries a "Contributing code / human-in-the-loop" section inCONTRIBUTING.mdthat none of the integration repositories have yet — worth aligningacross all repos in a separate PR.
Changelog