GLSP-1682: Update references to the consolidated glsp-core repo - #317
Merged
Merged
Conversation
The client framework and the Node server framework moved into the eclipse-glsp/glsp-core monorepo; the former glsp-client and glsp-server-node repos will be archived. - Point the docs at glsp-core: contribution guide, PR-target example URL, the landscape description in the README, and the Node server framework links of the node-json-* project templates - Clarify that `glsp-client`/`glsp-server` in the README denote folders of an example, now that `glsp-client` collides with the name of the archived repo - Fix the repository metadata of the workflow-glsp and workflow-server packages, which pointed at the soon-archived repos instead of glsp-examples - Retarget the update-workflow skill at glsp-core so it keeps working after archival: it is now cloned once and provides both the client and the Node server dev example Part of: eclipse-glsp/glsp#1682
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The client framework and the Node server framework moved into the
eclipse-glsp/glsp-coremonorepo; the formerglsp-clientandglsp-server-noderepos will be archived.This updates the references that would break or mislead after the archival. Docs and metadata only — no dependency or build changes.
node-json-*project templatesglsp-client/glsp-serverin the README denote folders of an example, now thatglsp-clientcollides with the name of the archived repo (no directories renamed)workflow-glspandworkflow-serverpackages, which pointed at the soon-archived repos instead ofglsp-examplesupdate-workflowagent skill at glsp-core so it keeps working after archival: it is now cloned once and provides both the client and the Node server dev examplePart of: eclipse-glsp/glsp#1682
How to test
Doc/metadata-only change; verified locally:
glsp-coreclone (packages/client,packages/server,examples/workflow-glsp,examples/workflow-server); default branch ismain, so thetree/main/...links are correcteclipse-glsp/glsp-client,eclipse-glsp/glsp-server-node,eclipse-glsp/glsp-playwrightreturns no hits (remainingglsp-clientmatches are local directory/package names)package.jsonfiles still parse as valid JSONupdate-workflowskill'sv<version>tag convention still holds — glsp-core carries the full tag history throughv2.8.0Follow-ups
enginesareyarn >=1.7 <2/node >=14.18.0while the README asks for Node>=20. The yarn → pnpm migration is a separate effort, intentionally out of scope here.@eclipse-glsp/*deps stay pinned at2.8.0until the first glsp-core release..github/PULL_REQUEST_TEMPLATE.md, unlike the other eclipse-glsp repos — worth adding separately.Changelog