GLSP-1682: Align repository with the glsp-core mono repo - #301
Merged
Merged
Conversation
The client, protocol, Node server and Playwright framework now live in eclipse-glsp/glsp-core, so the E2E setup and the repository references have to follow. - Rewire the E2E workflow: build the Workflow fatjar here, start it as a WebSocket server and run the standalone Playwright suites of glsp-core against it with GLSP_SERVER_TYPE=java, which makes the suites assert the Java server labels and skip the web-worker project. The glsp-client/glsp-playwright checkouts and the `glsp repo` CLI they provided are gone, so the server is started and awaited explicitly - Adopt the agent setup of glsp-core: AGENTS.md is the single source and CLAUDE.md only imports it, /verify becomes /fix (headers, build, checkstyle, tests) and both skills are mirrored under .agents for agents that do not read .claude - Point README and CONTRIBUTING at glsp-core instead of glsp-client and list the standalone client the README already promised Also: - Exclude .claude/** and .agents/** from the CI and E2E triggers Part of: eclipse-glsp/glsp#1682
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The client, protocol, Node server and Playwright framework now live in
eclipse-glsp/glsp-core, so the E2E setup and the repository references have tofollow.
server and run the standalone Playwright suites of
glsp-coreagainst it withGLSP_SERVER_TYPE=java, which makes the suites assert the Java server labels andskip the web-worker project. The
glsp-client/glsp-playwrightcheckouts and theglsp repoCLI they provided are gone, so the server is started and awaitedexplicitly
glsp-core:AGENTS.mdis the single source andCLAUDE.mdonly imports it,/verifybecomes/fix(headers, build, checkstyle,tests) and both skills are mirrored under
.agentsfor agents that do not read.claudeREADMEandCONTRIBUTINGatglsp-coreinstead ofglsp-clientand listthe standalone client the README already promised
Also:
.claude/**and.agents/**from the CI and E2E triggersPart of: eclipse-glsp/glsp#1682
How to test
Run the E2E workflow from the Actions tab (
workflow_dispatch), or reproduce itlocally:
/fixsteps run green (scoped header check,mvn clean verify -Pm2 -Pfatjar, checkstyle summary reports no violations)Follow-ups
glsp-core; if that turns out to be toovolatile, the checkout can be pinned to a tag.
glsp-coreadditionally carries a "Contributing code / human-in-the-loop" sectionin
CONTRIBUTING.mdthat neither this repo nor the Theia/VS Code integrations haveyet — worth aligning across all repos in a separate PR.
Changelog