Auto Assignment Migration Phase 4 - #3225
Open
kaloyanam wants to merge 1 commit into
Open
Conversation
|
Thanks @kaloyanam for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution. |
kaloyanam
force-pushed
the
feature/auto-assignment-approval-phase-4
branch
from
July 28, 2026 13:44
ee46175 to
5b44f4f
Compare
avgustinmm
requested changes
Jul 29, 2026
| TARGET_ADMIN + IMPLIES + SpPermission.APPROVE_AUTO_ASSIGNMENT + LINE_BREAK + | ||
| TARGET_ADMIN + IMPLIES + SpPermission.HANDLE_AUTO_ASSIGNMENT + LINE_BREAK; | ||
| TARGET_ADMIN + IMPLIES + SpPermission.HANDLE_AUTO_ASSIGNMENT + LINE_BREAK + | ||
| TARGET_ADMIN + IMPLIES + SpPermission.CREATE_AUTO_ASSIGNMENT + LINE_BREAK + |
Contributor
There was a problem hiding this comment.
maybe, TARGET_UPDATE shall imply CRUD AUTO_ASSIGNMENT permissions in order to keep current behavior.
Then no need for TARGET_ADMIN imply - it already imply TARGET_UPDATE
| "A sort criteria consists of the name of a field and the sort direction (ASC for ascending and DESC descending)." + | ||
| "The sequence of the sort criteria (multiple can be used) defines the sort order of the entities in the result.") | ||
| String sortParam | ||
| @RequestParam(value = MgmtRestConstants.REQUEST_PARAMETER_SEARCH, required = false) @Schema(description = "Query fields based on the Feed Item Query Language (FIQL). See Entity Definitions for available fields.") String rsqlParam, |
Contributor
There was a problem hiding this comment.
Return back formatting of API classes:
- easily readable
- compatible with rest of the class formattings
|
|
||
| body.add(linkTo(methodOn(MgmtAutoAssignmentRestApi.class).getAutoAssignment(body.getId())).withSelfRel().expand()); | ||
| if (targetFilterQuery.getAutoAssignStatus() == WAITING_FOR_APPROVAL) { | ||
| if (autoAssignment.getStatus() == WAITING_FOR_APPROVAL) { |
Contributor
There was a problem hiding this comment.
use switch - easily readable, one getStatus
|
|
||
| final DistributionSet distributionSet = filter.getAutoAssignDistributionSet(); | ||
| final DistributionSet distributionSet = autoAssignment == null ? null : autoAssignment.getDistributionSet(); | ||
| if (distributionSet != null) { |
Contributor
There was a problem hiding this comment.
it since autoAssignment == null <=> distributionSet == null better understandable would be if (authAssignment != null) { .. and then assume ds != null }
| /** | ||
| * @return RSQL query | ||
| */ | ||
| String getQuery(); |
Contributor
There was a problem hiding this comment.
getTargetFilterQuery as in Rollout and in REST api,
check if the rest of the methods are in sync with Rollout interface
| @Getter | ||
| public enum AutoAssignmentFields implements QueryField { | ||
|
|
||
| ID("id"), NAME("name"), CREATEDAT("createdAt"), CREATEDBY("createdBy"), LASTMODIFIEDAT("lastModifiedAt"), LASTMODIFIEDBY("lastModifiedBy"), |
Contributor
There was a problem hiding this comment.
follow the ordering (entry per line) of the rest Fields
| LASTMODIFIEDAT("lastModifiedAt"), | ||
| LASTMODIFIEDBY("lastModifiedBy"), | ||
| AUTOASSIGNDISTRIBUTIONSET("autoAssignDistributionSet", "name", "version"); | ||
| ID("id"), NAME("name"), CREATEDAT("createdAt"), CREATEDBY("createdBy"), LASTMODIFIEDAT("lastModifiedAt"), LASTMODIFIEDBY("lastModifiedBy"); |
Contributor
There was a problem hiding this comment.
Return ordering.
AUTOASSIGNDISTRIBUTIONSET removal shall be explicitly pointed out in commend - it is backward incompatible change - we shall check if we could keep the support.
| new AutoAssignDistributionSetUpdate(targetFilter.getId()).ds(ds2Type2.getId())); | ||
| }); | ||
| final AutoAssignment autoAssignment = callAs(withAuthorities( | ||
| CREATE_AUTO_ASSIGNMENT, |
Contributor
There was a problem hiding this comment.
UPDATE_TARGET shall be sufficient?
| }); | ||
| } | ||
|
|
||
| private AutoAssignment findAutoAssignment(final TargetFilterQuery filter) { |
Contributor
There was a problem hiding this comment.
this method shall be removed and replaced by findLinkedAutoAssignment everywhere? we dont link just by name?
kaloyanam
force-pushed
the
feature/auto-assignment-approval-phase-4
branch
2 times, most recently
from
July 30, 2026 09:07
16cbed0 to
480aac5
Compare
kaloyanam
marked this pull request as ready for review
July 30, 2026 09:29
avgustinmm
force-pushed
the
feature/auto-assignment-approval-phase-4
branch
from
July 30, 2026 12:31
480aac5 to
d30294c
Compare
…et filter query, migrate to a separate table in the database, fixed tests - Added a new `sp_auto_assignment` table and removed the auto-assignment fields from the `sp_target_filter_query` table - Updated the 1.20.3 Flyway migration to create `sp_auto_assignment` and drop the auto-assign columns from `sp_target_filter_query`. - Created a new `AutoAssignment` interface and a new `JpaAutoAssignment` - Created a new `AutoAssignmentManagement` and `JpaAutoAssignmentManagement` - Created an `AutoAssignmentRepository` - Added CRUD permissions for auto assignments - Auto assignments now can be updated - Auto assignment tests now separated in their own classes - Tests updated to match the new entity UI has been untouched, so it will not represent auto-assignments properly Signed-off-by: Marinov Kaloyan <kaloyan.marinov@bosch.com>
avgustinmm
force-pushed
the
feature/auto-assignment-approval-phase-4
branch
from
July 30, 2026 12:31
d30294c to
1530b90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Separate auto-assignments as a separate entity, independent from target filter query, migrate to a separate table in the database, fixed tests
Changes
sp_auto_assignmenttable and removed the auto-assignment fields from thesp_target_filter_querytablesp_auto_assignmentand drop the auto-assign columns fromsp_target_filter_query.AutoAssignmentinterface and a newJpaAutoAssignmentAutoAssignmentManagementandJpaAutoAssignmentManagementAutoAssignmentRepositoryNotes
UI has been untouched, so it will not represent auto-assignments properly