Skip to content

Issue #6380: Complete and correct the SPDX and NOTICE declarations of embedded third-party content - #6381

Merged
reckart merged 2 commits into
release/42.xfrom
refactoring/6380-Complete-and-correct-the-SPDX-and-NOTICE-declarations-of-embedded-third-party-content
Nov 15, 2026
Merged

reckart merged 2 commits into
release/42.xfrom
refactoring/6380-Complete-and-correct-the-SPDX-and-NOTICE-declarations-of-embedded-third-party-content

Conversation

@reckart

@reckart reckart commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

What's in the PR

  • Replace the Apache header on the four Font Awesome icons with the Font Awesome attribution, and license the icons as CC BY 4.0 including the TU Darmstadt modifications
  • Exclude the four Font Awesome icons from the RAT header check in inception-assistant-ui and inception-processing
  • Declare embedded third-party code used in production that had no SPDX entry: RDF4J Lucene SAIL, PDFBox glyph positioning, jsoup methods, brat scrollbarWidth, the Wicketstuff ContextMenu template and the AnnoLab Trie
  • Point stale SPDX entries at the files' current locations, including the brat sources, the pdfjs assets copied into the jar, AjaxDownloadBehavior and the focus patch
  • Restore the original AnnoLab copyright header in Trie.java and move its attribution into inception-support
  • Remove the SPDX and NOTICE files of modules that no longer embed third-party code (inception-imls-stringmatch, inception-kb, inception-ui-core) and the RAT exclusion for the removed Bind.java
  • Update NOTICE.txt files to match the declarations
  • Replace third-party RDF and CoNLL test fixtures with self-written data, keeping a FinnTreeBank-free German CoNLL/RDF round trip for RdfWriterTest
  • Remove unused and unlicensed third-party data: the Wine Ontology KB profile, template and data, the Stanford Dependencies and STTS tagsets, and the test copies of wildlife, OLiA, WordNet, Plant Ontology and playground data
  • Add own test fixtures for OBO import, OWL roots, intersection classes, library ontology, custom label properties, RDF/XML with DOCTYPE entities, and streams with implicit classes and instances
  • Add a parent-list test and extend the child-concept, roots and OBO import tests with stronger assertions
  • Add tests for DOCTYPE entity import and external entity non-expansion, and enable the previously disabled RDF round trip test
  • Add a rate-limit retry strategy for remote test repositories, with unit tests
  • Make test downloads follow cross-protocol redirects and skip only on temporary errors
  • Add a local library ontology configuration to the remote KB test so it runs without network access
  • Switch the Wikidata KB tests to a stable class (chemical element)
  • Re-enable the Virtuoso query builder tests: pin the image to 7.2.16, update the full-text index after each import, and exclude five scenarios with documented reasons
  • Declare the Universal Dependencies documentation tagsets in an SPDX file and NOTICE, and add the Apache header to the test Turtle files
  • Update user guide examples to use Wikidata IRIs and German sample data
  • Clarify the RdfImportParserConfigs Javadoc with the new fixture and OLiA

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

… embedded third-party content

- Replace the Apache header on the four Font Awesome icons with the Font Awesome attribution, and license the icons as CC BY 4.0 including the TU Darmstadt modifications
- Exclude the four Font Awesome icons from the RAT header check in inception-assistant-ui and inception-processing
- Declare embedded third-party code used in production that had no SPDX entry: RDF4J Lucene SAIL, PDFBox glyph positioning, jsoup methods, brat scrollbarWidth, the Wicketstuff ContextMenu template and the AnnoLab Trie
- Point stale SPDX entries at the files' current locations, including the brat sources, the pdfjs assets copied into the jar, AjaxDownloadBehavior and the focus patch
- Restore the original AnnoLab copyright header in Trie.java and move its attribution into inception-support
- Remove the SPDX and NOTICE files of modules that no longer embed third-party code (inception-imls-stringmatch, inception-kb, inception-ui-core) and the RAT exclusion for the removed Bind.java
- Update NOTICE.txt files to match the declarations

Assisted-by: Anthropic Claude (claude-opus-5-5)
@reckart reckart added this to the 42.4 milestone Nov 14, 2026
@reckart reckart self-assigned this Nov 14, 2026
… embedded third-party content

- Replace third-party RDF and CoNLL test fixtures with self-written data, keeping a FinnTreeBank-free German CoNLL/RDF round trip for RdfWriterTest
- Remove unused and unlicensed third-party data: the Wine Ontology KB profile, template and data, the Stanford Dependencies and STTS tagsets, and the test copies of wildlife, OLiA, WordNet, Plant Ontology and playground data
- Add own test fixtures for OBO import, OWL roots, intersection classes, library ontology, custom label properties, RDF/XML with DOCTYPE entities, and streams with implicit classes and instances
- Add a parent-list test and extend the child-concept, roots and OBO import tests with stronger assertions
- Add tests for DOCTYPE entity import and external entity non-expansion, and enable the previously disabled RDF round trip test
- Add a rate-limit retry strategy for remote test repositories, with unit tests
- Make test downloads follow cross-protocol redirects and skip only on temporary errors
- Add a local library ontology configuration to the remote KB test so it runs without network access
- Switch the Wikidata KB tests to a stable class (chemical element)
- Re-enable the Virtuoso query builder tests: pin the image to 7.2.16, update the full-text index after each import, and exclude five scenarios with documented reasons
- Declare the Universal Dependencies documentation tagsets in an SPDX file and NOTICE, and add the Apache header to the test Turtle files
- Update user guide examples to use Wikidata IRIs and German sample data
- Clarify the RdfImportParserConfigs Javadoc with the new fixture and OLiA

Assisted-by: Anthropic Claude (claude-opus-5-5)
@reckart
reckart merged commit 39c1075 into release/42.x Nov 15, 2026
6 checks passed
@reckart
reckart deleted the refactoring/6380-Complete-and-correct-the-SPDX-and-NOTICE-declarations-of-embedded-third-party-content branch November 15, 2026 08:18
@reckart reckart changed the title Issue #6380: Complete and correct the SPDX and NOTICE declarations of… Issue #6380: Complete and correct the SPDX and NOTICE declarations of embedded third-party content Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant