feat: add programmatic api for cli - #2013
Draft
netomi wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
@gnugomez can you take a look and respond if this goes in the right direction? |
gnugomez
reviewed
Jul 30, 2026
Comment on lines
30
to
32
| "main": "lib/index", | ||
| "types": "lib/index", | ||
| "bin": "bin/ovsx", |
Member
There was a problem hiding this comment.
suggestion: I think that for clarification we should add the proper file extensions
It might work either way, at least for the main entry point it will surely work, I'm not completely sure for the types tho.
"main": "lib/index.js",
"types": "lib/index.d.ts",
"bin": "bin/ovsx"if that was consumed like this before and worked please ignore my comment
gnugomez
approved these changes
Jul 30, 2026
gnugomez
left a comment
gnugomez
left a comment
Member
There was a problem hiding this comment.
the code is looking good to me
I would suggest to improve a bit the documentation we're adding since there's some other functions being exported that are not even mentioned (I'm talking about all the namespace related ones).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1591.
This is the first attempt to provide an api for functionality like
publishVSIX.It also bumps to node 22 as 20 is anyway unmaintained and vitest requires at least 22.