Repository navigation
fix: dump live omp sessions with confirmation and redaction - #331
Merged
Merged
Conversation
edheltzel
force-pushed
the
fix/omp-dump-source
branch
from
October 15, 2026 00:35
0dd5b7a to
b0510a5
Compare
…tool omp sets CLAUDECODE=1 as well as OMPCODE=1, and session discovery only knew Claude, OpenCode and Pi, so recall dump from omp imported the newest Claude transcript. Session files cannot identify omp's live branch or profile, so the omp extension now registers a recall_dump tool that sends its live getBranch() text and session id to dist/index.js dump --stdin (new contract 1 input) after the user confirms in the omp UI. Inside omp, file discovery returns nothing and recall dump points at the tool.
…tion and dispatch
An empty supplied session (dump --stdin with no messages, or text that scrubs to nothing) reached coreDump, which cleared a non-lifecycle session's messages before finding nothing to import.
…reaking id contiguity
… LoA is reused and rescrubbed
…ding over blank rows
edheltzel
force-pushed
the
fix/omp-dump-source
branch
from
October 16, 2026 17:27
b0510a5 to
f9c55c2
Compare
edheltzel
pushed a commit
that referenced
this pull request
Oct 17, 2026
* fix(dump): dump the live omp session through a confirmed recall_dump tool omp sets CLAUDECODE=1 as well as OMPCODE=1, and session discovery only knew Claude, OpenCode and Pi, so recall dump from omp imported the newest Claude transcript. Session files cannot identify omp's live branch or profile, so the omp extension now registers a recall_dump tool that sends its live getBranch() text and session id to dist/index.js dump --stdin (new contract 1 input) after the user confirms in the omp UI. Inside omp, file discovery returns nothing and recall dump points at the tool. * no-mistakes(review): Fix dump scrubbing, project attribution, and behavioral coverage * no-mistakes(review): Propagate omp dump cancellation through confirmation and dispatch * no-mistakes(document): Clarify dump contracts and consolidate credential guidance * fix(dump): reject empty sessions before clearing an existing dump An empty supplied session (dump --stdin with no messages, or text that scrubs to nothing) reached coreDump, which cleared a non-lifecycle session's messages before finding nothing to import. * fix(dump): pass omp titles after -- and scrub legacy snapshots before matching * fix(dump): match legacy snapshots whose rows scrub to blank without breaking id contiguity * fix(dump): keep blank legacy rows in the matched span so the existing LoA is reused and rescrubbed * fix(dump): include leading and trailing blank legacy rows in the matched snapshot * fix(dump): match legacy LoAs by non-blank source ids instead of expanding over blank rows * no-mistakes(document): Clarify omp dump limits and discovery guidance --------- Co-authored-by: Atlas-Key <296298943+Atlas-Key@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
recall_dumptool that saves the live branch and session ID, supports cancellation, and blocks transcript discovery inside omp.recall dump --stdininput with origin-based project attribution and rejection of empty sessions before writes.Risk Assessment
✅ Low: The changes are bounded, and static tracing found no new actionable defects beyond the concerns already covered by recorded user decisions.
Testing
Build, focused regressions, packaged-plugin checks, and real omp TUI/RPC plus CLI/MCP scenarios passed using isolated data and local provider fixtures. Captured terminal images, transcripts and persisted state; removed transient files. Full-suite, lint and CI phases were not run.
Evidence: Approved dump persisted state
Evidence: Fork selection and confirmation abort
Evidence: Named-profile saved state
Evidence: Decline, dismissal and headless results
~/.no-mistakes/evidence/01M52TPCFZ70T760RP88K5214K/cli-mcp-transcript.json)Evidence: Native host dumps and legacy snapshot state
Evidence: Validation manifest
~/.no-mistakes/evidence/01M52TPCFZ70T760RP88K5214K/live-validation-drivers.tar.gz)Pipeline
Updates from git push no-mistakes
⏭️ **intent** - skipped
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
bun install --frozen-lockfileandbun run buildbun test tests/commands/dump-portable.test.ts tests/omp-integration.test.tswith disposable HOME, TMPDIR, RECALL_HOME and databasepython3 .local-test-omp/omp_visual.pypython3 .local-test-omp/live_omp.pypython3 .local-test-omp/rpc_live.pypython3 .local-test-omp/profile_check.pybun .local-test-omp/cli_check.tsbun .local-test-omp/legacy_hosts.tsbun .local-test-omp/e2e-omp-isolated.ts— existing packaged-plugin E2E with isolated provider/cache pathspython3 .local-test-omp/terminal_to_svg.pyandbun .local-test-omp/render.mjs; inspected generated terminal imagesRemoved disposable fixtures, generated builds and phase-installed dependencies; verified temporary package changes were restored.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.