Repository navigation
Conversation
Visual recap β skippedThe visual recap job did not run for this pull request. This is informational only and does not block the PR. Recap skipped for |
There was a problem hiding this comment.
β No new issues found.
Reviewed changes
Reviewed the full diff for the standalone aup updater, its manifest, tests, and just recipe. Fish aup, topgrade, and upp are unchanged.
- Manifest β
config/.config/aup/harnesses.tomllists 11 harnesses in run order. List-form args stay intact for Plannotator. - Updater β skips a missing binary, keeps going after a failed step, and exits non-zero if any step failed.
~/.local/state/aup/last.logopens only after the manifest and--onlycheck pass. - TTY and PATH β children get the terminal when stdout is a TTY; otherwise output is piped and copied to the log with SGR codes stripped. Known tool dirs are appended and do not reorder the inherited PATH.
- Build β
just aupbuildstools/aupinto~/.local/bin/aup. Cutover is left for a later change, as described.
grok-4.7 ο½ π
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this is
aupis a small standalone Go tool intools/aup. It updates the 11 agent harnesses listed in a manifest (config/.config/aup/harnesses.toml, a copy of the fish manifest).~/.local/state/aup/last.log(colour codes stripped). The log is only opened after the manifest and--onlycheck pass.PATH(Homebrew first) without reordering the PATH it inherited.--dry-run,--only <name>,--manifest <path>.just aupbuilds it into~/.local/bin/aup.What is not changed
The fish
aupfunction, topgrade'scustom.tomlline and theuppabbreviation are untouched. Nothing changes for anyone until a later cutover.Commits
ed4b8ffefeat(config): add aup harness manifest49e25888feat(aup): add Go updater for agent harnesses30d25f51test(aup): cover skip, isolation, dry-run, filter, duplicates, log, colour9b08822efeat(just): add aup build recipe3a614c73fix(aup): put homebrew dirs before ~/.local/bin on PATHee9d138cfix(aup): give children the terminal when stdout is a TTY9038758efix(aup): append known dirs to PATH instead of reordering iteec04e7afix(aup): open the log after validation and strip colour from it55a288edchore(aup): go mod tidyAll commits are SSH-signed.
How it was tested
go vetandgofmt -lall clean.go mod tidy -diffis clean.NO_COLOR=1: 11 would run, 0 failed, 0 skipped.New dependency:
github.com/creack/pty, used only by the pty test. The other dependency isBurntSushi/toml.Not included
Follow-ups (v2)
uppataup, then deleteaup.fishand the fish manifest.brew --version, which reports Homebrew's version.