EPBDS-16211 F1 step 5: record the bundle delta, close the step (release deferred) - #47
Merged
Merged
Conversation
…se deferred) THE BUNDLE DELTA — MEASURED, and the estimate it replaces was low by 6.7×. Step 5 asked to "record the bundle delta (−30 KB+ per the source's own estimates: 27 KB Dropdown + 4 KB Table + Popup)". Those came from comments and had never been checked. Measured by building the library at c754daf — the commit before step 1, where all three components still wrapped SUIR — and comparing: dist/index.js 436,690 -> 333,529 -103,161 (-23.6%) gzip -33,486 static/all.css 407,288 -> 307,785 -99,503 (-24.4%) gzip -10,316 TOTAL 843,978 -> 641,314 -202,664 (-24.0%) gzip -43,802 The estimate counted only the JS weight of three components and had no CSS term at all; half the saving is stylesheet. The gzip column is the one that describes a page load: ~44 KB less transferred, every time. The baseline build also demonstrated what the exit removed, by failing: a clean `npm ci` at that commit could not build until `theme.config` was copied into `node_modules/semantic-ui-less/` by hand. THE DOCUMENTATION HALF — brought TRUE, not merely finished. Three changelog statements were wrong, two of them written during this workstream: - that the Semantic *styles* are still loaded — they were vendored at step 4, and the claim contradicted an entry 25 lines above it; - that the tooltip "has been in-house for two releases" — it has shipped in NONE. `git tag --contains` is empty for that commit; - stale tarball figures (295 files / 7.25 MB; now 299 / 6.7 MB / 2.5 MB packed). Two tooltip facts were missing and are added: the object-`tooltip` passthrough narrowing from 45 names to 13, and the WCAG SC 1.4.13 non-conformance stated plainly rather than left to be discovered. `docs/SUPPORTED-PROPS.md` still carried a "Step 3 — Dropdown" block of unmet obligations that the same page discharges, and a live "forwarded to semantic-ui-react" outcome with its tier vocabulary. Corrected at the source, since the page is generated; the tiers are retired with an explanation of what they encoded and why it no longer applies. THE STEP-5 GATE WAS UNSATISFIABLE AS WRITTEN and is fixed rather than ticked: Appendix B's second grep matched our own prose comments and the legitimate imports of the vendored CSS, so it could never return nothing. Replaced by three commands that express the actual invariant — no `semantic-ui-react` import, no LESS import reaching either package, neither package in the manifest. All three return nothing. ALSO: 16 Appendix C boxes ticked with what discharged them; R2 and R16 retired; §2.6-7 (published CSS leaks) and both `engines >=22` claims corrected to what the manifest actually says; §10 rows 5a/5b marked, with 5b noting that "own the 5 LESS modules" is not what happened — three were measured unused and deleted. CONSUMER REACHABILITY, added because a MINOR that removes published props has to be actionable: `docs/SUPPORTED-PROPS.md` and `docs/SUPPORTED-VIEWS.md` now ship IN the tarball, and the manifest gained `repository` and `bugs`. DEFERRED DELIBERATELY: the release itself. Neither `npm publish` nor `npm run build && npm run deploy` is taken here — master still carries React 17+18 and the whole F1 exit unreleased, and `### Unreleased` is accurate. NOT step 5 and still open: the §9.8 LESS-pin re-evaluation (its trigger was "right after step 4"), and `watch-lib`'s divergence from the published build. Gates: jsdom 167 suites / 2540 tests / 38 snapshots; `lint:js`, `lint:css`, `css:fixture:check`, both docs checks, `build-lib` and `sync-version --check` green; published CSS still byte-identical (dcdb0a40…).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes §9.7-F1 step 5 — except the release itself, which is deliberately deferred.
The bundle delta, measured — the estimate it replaces was low by 6.7×
Step 5 asked to "record the bundle delta (−30 KB+ per the source's own estimates: 27 KB Dropdown + 4 KB Table + Popup)". Those came from comments in the source and had never been checked. Measured by building the library at
c754daf5— the commit before step 1, where all three components still wrapped SUIR — and comparing with master:dist/index.jsstatic/all.cssThe estimate counted only the JS weight of three components and had no CSS term at all — half the saving is stylesheet. The gzip column is the one that describes a page load: ~44 KB less transferred, every time.
The baseline build also demonstrated what the exit removed, by failing: a clean
npm ciat that commit could not build untiltheme.configwas copied intonode_modules/semantic-ui-less/by hand.The documentation half — brought true, not merely finished
Three changelog statements were wrong, two of them written during this workstream:
git tag --containsis empty for that commit;Two tooltip facts were missing and are added: the object-
tooltippassthrough narrowing from 45 names to 13, and the WCAG SC 1.4.13 non-conformance stated plainly rather than left to be discovered.docs/SUPPORTED-PROPS.mdstill carried a "Step 3 — Dropdown" block of unmet obligations that the same page discharges, and a live "forwarded to semantic-ui-react" outcome with its tier vocabulary. Corrected at the source, since the page is generated.The step-5 gate was unsatisfiable, and is fixed rather than ticked
Appendix B's second grep matched our own prose comments and the legitimate imports of the vendored CSS — it could never return nothing. Replaced by three commands that express the actual invariant: no
semantic-ui-reactimport, no LESS import reaching either package, neither package in the manifest. All three return nothing.Also
16 Appendix C boxes ticked with what discharged them; R2 and R16 retired; §2.6-7 ("published CSS leaks global styles") and both
engines >=22claims corrected to what the manifest says; §10 rows 5a/5b marked — with 5b noting that "own the 5 LESS modules" is not what happened, since three were measured unused and deleted.Consumer reachability, added because a MINOR that removes published props has to be actionable:
docs/SUPPORTED-PROPS.mdanddocs/SUPPORTED-VIEWS.mdnow ship in the tarball, and the manifest gainedrepositoryandbugs.Deferred and still open
masterstill carries React 17+18 and the whole F1 exit unreleased, and### Unreleasedis accurate.watch-lib's divergence from the published build.Gates
jsdom 167 suites / 2540 tests / 38 snapshots;
lint:js,lint:css,css:fixture:check, both docs checks,build-libandsync-version --checkgreen; published CSS still byte-identical (dcdb0a40…).🤖 Generated with Claude Code