Remove fork-PR regeneration from changelog/upload and drop invalid inputs from sync - #319
Merged
Merged
Conversation
upload action does not accept owner/repo — drops the warning. Merged-fork-PR step needs pull-requests: read to query PR data. Co-Authored-By: Claude <noreply@anthropic.com>
Mpdreamz
force-pushed
the
fix/release-notes-secrets-and-cleanup
branch
from
August 31, 2026 17:57
8a556a9 to
9aae7fd
Compare
Mpdreamz
changed the title
Retroactively generating changelog entries on merge bypasses the PR gate: any repo requiring a changelog file would silently pass for fork PRs, then get an auto-generated entry injected by sync. Fork PRs that can't push a changelog file must add one manually during the PR — sync should only upload files already checked in. Removes the step and the pull-requests: read permission it needed. Co-Authored-By: Claude <noreply@anthropic.com>
Mpdreamz
changed the title
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the
syncjob path: removes a step that was architecturally wrong, and drops inputs thatuploadnever accepted.Affects: CI/CD, changelog pipeline
Why
The
uploadaction contained a step that looked up merged fork PRs for the pushed commit and retroactively generated changelog entries for them. This is the wrong place: any repo requiring a changelog file would silently pass that PR gate for fork PRs, then get an auto-generated entry injected at merge time by sync. Fork PRs that cannot push a changelog entry must add one manually during the PR — sync should only upload files that were already checked in.The step also required
pull-requests: readon the sync job (to call/commits/{sha}/pulls), which every consumer of the sharedrelease-notes.ymlpays even if they never accept fork PRs.Additionally, the
release-notes.ymlsync job was passingownerandrepoto theuploadaction, which does not declare those inputs, producing a##[warning]on every run.What
Remove the fork-PR regeneration step from
changelog/uploadDeletes the "Add changelog entries for merged fork PRs" step entirely. Fork PR handling belongs at PR time, not at merge time.
Drop
owner/repofrom the upload step inrelease-notes.ymlThe action derives repo context from the GitHub environment. Neither input is declared or used.