revert: remove aws-role-arn input from bundle-upload - #331
Merged
Conversation
theletterf
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #314.
The promotion workflow in
elastic/docs-internal-workflowsinlines the three upload steps directly (configure-aws-credentialswith the hardcoded role ARN,docs-builder/setup,docs-builder changelog upload) instead of routing through this action with a caller-supplied role. No changes todocs-actionsare needed for the promotion use case.Adding an
aws-role-arnparameter to a public shared action for a single internal caller in a private repo is the wrong direction for the dependency.🤖 Generated with Claude Code