Add profile-specific output_directory - #3987
Open
lcawl wants to merge 1 commit into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This is a follow-up to #3985 and #3984
Per #3856 (comment) the changes in #3856 meant that it was no longer possible to use profiles to generate multiple bundles in unique directories in a single repo. This is necessary for repos that have multiple release note pages and changelog directives that reference local bundles. None of the currently-migrated Elastic release note pages are in this situation anymore (they're all using bundles derived from the CDN), however it is a breaking change and IMO should be fixed. Otherwise we need to clearly call this out as a method that's no longer supported.
Summary
Adds profile-specific
output_directory.Details
output_directoryreplacesbundle.output_directoryfor that profile (same as option-mode--outputwhen it is a directory). The file is still{repo}-{product}-{version}.yaml..yml/.yamlvalue is a hard error;output:stays a hard error.--planuses the same path.changelog upload(without--directory) scans the global output dir and each profileoutput_directory, each non-recursively.docs-actions still needs no code change; only README wording there is a separate follow-up: elastic/docs-actions#320
Generative AI disclosure
Tool(s) and model(s) used: Cursor Grok 4.6