Remove legacy PR Buildkite Detective workflow - #7776
Conversation
Install trigger-obs-aw client workflows from elastic/oblt-aw and remove the legacy direct lock invocation for gh-aw-estc-pr-buildkite-detective.
There was a problem hiding this comment.
🟡 Changes recommended
The new reusable-workflow references are pinned to the mutable @main ref and explicitly exclude pinning (ratchet:exclude), creating an avoidable supply-chain and auditability risk for CI automation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR migrates the PR Buildkite Detective automation from a legacy direct workflow invocation to the Observability Agentic Workflow (obs-aw) “status” routing, aligning Fleet Server’s GitHub Automation entrypoints with the shared control-plane driven workflow orchestration model.
Changes:
- Removed the legacy
PR Buildkite Detectivestatus-triggered workflow that directly invokedgh-aw-estc-pr-buildkite-detective.lock.yml. - Added obs-aw trigger entrypoints for
status,schedule,pull_request,issues, andissue_commentevents that delegate to reusable workflows inelastic/oblt-aw. - Wired the Buildkite failure status path to pass
BUILDKITE_LOGS_API_TOKENasBUILDKITE_API_TOKENinto the obs-aw status reusable workflow.
File summaries
| File | Description |
|---|---|
| .github/workflows/trigger-pr-buildkite-detective.yml | Removed legacy Buildkite detective workflow entrypoint. |
| .github/workflows/trigger-obs-aw-status.yml | Added status-trigger entrypoint delegating Buildkite-failure routing to obs-aw. |
| .github/workflows/trigger-obs-aw-schedule.yml | Added scheduled/dispatch entrypoint for obs-aw orchestration. |
| .github/workflows/trigger-obs-aw-pull-request.yml | Added pull request event entrypoint for obs-aw orchestration. |
| .github/workflows/trigger-obs-aw-issues.yml | Added issues/dispatch entrypoint for obs-aw orchestration. |
| .github/workflows/trigger-obs-aw-issue-comment.yml | Added issue comment entrypoint for obs-aw orchestration. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| id-token: write | ||
| issues: write | ||
| pull-requests: write | ||
| uses: elastic/oblt-aw/.github/workflows/obs-aw-event-issue-comment.yml@main # ratchet:exclude |
| id-token: write | ||
| issues: write | ||
| pull-requests: write | ||
| uses: elastic/oblt-aw/.github/workflows/obs-aw-event-issues.yml@main # ratchet:exclude |
| id-token: write | ||
| issues: write | ||
| pull-requests: write | ||
| uses: elastic/oblt-aw/.github/workflows/obs-aw-event-pull-request.yml@main # ratchet:exclude |
| id-token: write | ||
| issues: write | ||
| pull-requests: write | ||
| uses: elastic/oblt-aw/.github/workflows/obs-aw-event-schedule.yml@main # ratchet:exclude |
| id-token: write | ||
| issues: write | ||
| pull-requests: write | ||
| uses: elastic/oblt-aw/.github/workflows/obs-aw-event-status.yml@main # ratchet:exclude |
|
This pull request does not have a backport label. Could you fix it @fr4nc1sc0-r4m0n? 🙏
|
Drop the previously added trigger-obs-aw client templates; distribute-client-workflow will install those after control-plane registration merges.
There was a problem hiding this comment.
🔵 Needs a closer look
The legacy detective trigger is removed but no replacement trigger-obs-aw-* workflow exists in this repo today, so merging can interrupt detective coverage unless the external distribution prerequisite is already in place.
Review details
Suppressed comments (1)
.github/workflows/trigger-pr-buildkite-detective.yml:1
- This change deletes PR Buildkite Detective entirely, and there is currently no replacement
trigger-obs-aw-*workflow in this repo; merging as-is will disable detective coverage until the external distribute-client-workflow PRs land. Consider adding the replacement trigger workflow in this PR (or as a prerequisite PR) to avoid an interruption in triage automation.
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
Summary
gh-aw-estc-pr-buildkite-detective.lock.yml.trigger-obs-aw-*.ymlworkflows are installed bydistribute-client-workflowafter the control-plane registration merges (Register estc-pr-buildkite-detective consumers in obs active repositories oblt-aw#1852).Merge gate
Do not merge this PR until the oblt-aw distribution process has opened and merged the install PR that adds
trigger-obs-aw-*.yml(especiallytrigger-obs-aw-status.yml) to this repository. Merging the legacy removal first would leave Buildkite status failures without a detective entrypoint.Notes
obs:estc-pr-buildkite-detectiveon the[oblt-aw] Control Plane Dashboardissue (default is off).BUILDKITE_LOGS_API_TOKEN(already used by the legacy workflow where present).Test plan
trigger-obs-aw-status.ymlis present via distribute-client-workflow