do not write process.exitCode on exit - #1100
Merged
Merged
Conversation
Contributor
Contributor
|
🚀 Deployed on https://6a8eec9417f400dee28d7966--pglite.netlify.app |
AntonOfTheWoods
added a commit
to pgxsinkit/pglite
that referenced
this pull request
Sep 12, 2026
Moved pgx-publish onto upstream/main (0.5.8, ae182ff). The remaining stack carries only changes still absent upstream: transaction-end sync (plus the already-closed-transaction completion), the IDBFS durability hardening and relaxed-concurrency restore, the non-exclusive relaxed-sync latch (scoped), the opfs-ahp instrumentation, the close() relaxed-sync drain, the BasePGlite export and the live-query refresh/diff-key fixes. Dropped: the explicit-zero exit-code restore (0.5.5-pgx.2, and its changeset). Upstream electric-sql#1087 and electric-sql#1100 removed the process.exitCode save/restore sites entirely — the engine now reports exit status through _pgl_setPGliteExitStatus — so the helper had nothing left to restore. Its version-bump commit is kept as history. Conflicts re-applied onto the new base: - pglite.ts close(): kept the hardened structure (transaction/query mutex nesting, pending-sync drain, deferred final-sync and close-hook failures, closeFs in a finally, no serialize.end()) and replaced the folded electric-sql#1059 exitCode save/restore with upstream 0.5.8's exit tail — force_exit(0) with `this.mod = undefined` in the finally. - pglite.ts #init(): upstream removed the prevExitCode capture and its restore that bracketed the method, so the fork's #cleanupFailedInit, #initialSyncFs and #syncToFsStrict now follow a bare closing brace. - pglite.ts execProtocolRawSync(): upstream's body — the _pgl_setPGliteExitStatus(-2) longjmp check and a finally with no exit-code restore — plus the fork's #checkSynchronousFsSyncState() prologue. - packages/pglite/package.json: upstream's rewritten test:bun script kept alongside the fork's package name, repository url and publish:pgx:* scripts. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019muxX7JzHorerHQedWXRoz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.