Skip to content

build(deps-dev): upgrade vitest to v5 - #139

Merged
MarshallOfSound merged 1 commit into
mainfrom
vitest-5
Sep 23, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
vitest-5

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Requested by David Sanders · Slack thread

This upgrades vitest from v4 to 5.0.1. Vitest 5 makes vite a required peer instead of a dependency, so vite is now listed as a devDependency (^8.0.16, the version previously in the lockfile). With vite as a direct dependency, yarn also flagged that @types/node ~22.10.7 does not satisfy the ^22.12.0 || >=24.0.0 range vite and vitest ask for, so it moves to ~22.12.0, which matches the package's engines.node floor. No test or config changes were needed; lint, build, typecheck, and all 16 tests pass locally on Linux, including the ones against the downloaded Electron binaries.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF
@claude
claude Bot requested a review from a team as a code owner September 23, 2026 21:26
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedvitest@​4.1.11 ⏵ 5.0.198 +110079 +198100
Updated@​types/​node@​22.10.10 ⏵ 22.12.0100 +110081 +196100
Addedvite@​8.3.0991008296100

View full report

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, straightforward dev-dependency bump. Reviewed package.json (vitest v4→v5, new vite ^8.0.16 devDependency, @ types/node bumped to ~22.12.0) and confirmed yarn.lock changes are consistent with these version bumps with no production dependency or source code changes.

Extended reasoning...

The diff touches only package.json and yarn.lock: three devDependency changes (@ types/node 22.10.7→22.12.0, vitest ^4.1.2→^5.0.1, new vite ^8.0.16) with the lockfile regenerated to match. No production dependencies, application code, auth, or security-sensitive surfaces are touched. The change is small, mechanical, and matches the PR description exactly, so a human need not review it.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) September 23, 2026 23:13
@MarshallOfSound
MarshallOfSound merged commit 6b76d02 into main Sep 23, 2026
10 checks passed
@MarshallOfSound
MarshallOfSound deleted the vitest-5 branch September 23, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants