Skip to content

ci: add required-ci gate job - #140

Merged
dsanders11 merged 1 commit into
mainfrom
ci/required-ci-gate
Sep 29, 2026
Merged

dsanders11 merged 1 commit into
mainfrom
ci/required-ci-gate

Conversation

@claude

@claude claude Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

This adds a single required-ci job to the Test workflow that depends on the test job and fails if it failed or was cancelled, so branch protection can require one stable check name instead of each matrix leg, matching electron/forge. Branch protection or the ruleset needs updating separately to require it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Rx13DJRnFBvVNh1ioMMXsQ


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rx13DJRnFBvVNh1ioMMXsQ
@claude
claude Bot requested a review from a team as a code owner September 27, 2026 07:16

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, straightforward CI config change. Reviewed the new required-ci job: it depends on test and uses needs.test.result correctly to fail on failure/cancelled (the matrix test job's aggregate result reflects any failing OS leg), and the if: always() ensures it runs even when test fails. This is a standard aggregate-status-check pattern for branch protection with matrix jobs and introduces no security-sensitive surface.

Extended reasoning...

Single-file GitHub Actions workflow change adding a required-ci gate job that depends on the existing matrix test job and fails if it failed/cancelled, otherwise succeeds — a well-known pattern for stable required-status-check names. No security-sensitive code (auth, crypto, permissions) is touched, permissions are already scoped to contents: read, and the logic correctly handles the matrix job's aggregated result. Change is small, mechanical, and self-contained, so approving.

@dsanders11
dsanders11 enabled auto-merge (squash) September 29, 2026 06:40
@dsanders11
dsanders11 merged commit c74993f into main Sep 29, 2026
11 checks passed
@dsanders11
dsanders11 deleted the ci/required-ci-gate branch September 29, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants