SourceView: Save and restore selection when focus out and in#1713
Closed
jeremypw wants to merge 3 commits into
Closed
SourceView: Save and restore selection when focus out and in#1713jeremypw wants to merge 3 commits into
jeremypw wants to merge 3 commits into
Conversation
# Conflicts: # src/Services/Document.vala # src/Structs/SelectionRange.vala
Collaborator
Author
|
CLosing as stripping no longer takes place if there is a selection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was noticed that since #1663, it is possible to accidentally stray into the terminal pane when selecting text and this causes the selection to be lost.
There does not seem to be an advantage in losing the selection when the document focuses out so this PR saves and restores the selection on focus out/in.
Opinion sought whether this behaviour is undesirable under some circumstances and whether it is worth making optional.
Note that the selection is also now maintained when switching tabs.