Skip to content

Fix: Conversion banner layout spacing in WP admin [TMZ-1083] - #701

Merged
Ntnelbaba merged 2 commits into
mainfrom
TMZ-1083-fix-conversion-banner-layout
Sep 16, 2026
Merged

Ntnelbaba merged 2 commits into
mainfrom
TMZ-1083-fix-conversion-banner-layout

Conversation

@Ntnelbaba

@Ntnelbaba Ntnelbaba commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove redundant mr: 2 and width: '100%' from the conversion banner Welcome paper styles so the banner follows its admin container width and spacing.

Test plan

  • Open a wp-admin screen where the Hello conversion banner appears (e.g. Plugins or Themes).
  • Confirm the banner is not pushed inward by extra right margin and does not overflow horizontally.
  • Dismiss the banner and confirm it still hides correctly.

Jira

TMZ-1083

image

✨ PR Description

1. Problem & Context

Resolves layout spacing issues for the conversion banner in WP admin (TMZ-1083).

2. What Changed (Where)

  • modules/admin-home/assets/js/hello-elementor-conversion-banner.js: Removed mr: 2 and width: '10%' from the Welcome component styles.

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

Co-authored-by: Cursor <cursoragent@cursor.com>
@Ntnelbaba
Ntnelbaba enabled auto-merge (squash) September 15, 2026 10:10
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

Hello Elementor Build

Last updated at: 20260915.1010
Version: 3.5.1

✅ Hello Elementor build is ready for download.

You can download the latest build from the link below:

🔗 hello-elementor.3.5.1.zip

The build is available for 7 days.

@github-actions

Copy link
Copy Markdown

WordPress Theme Check

Status: passed (exit code 0)

Ran Theme Check against the packaged hello-elementor zip.

ℹ Starting 'bash hello-elementor-config/theme-check.sh' on the cli container. 

Installing Theme Check (20260901)
Downloading installation package from https://downloads.wordpress.org/plugin/theme-check.20260901.zip...
Unpacking the package...
Installing the plugin...
Removing the old version of the plugin...
Plugin updated successfully.
Activating 'theme-check'...
Plugin 'theme-check' activated.
Success: Installed 1 of 1 plugins.
Unpacking the package...
Installing the theme...
Removing the old version of the theme...
Theme updated successfully.
Activating 'hello-elementor'...
Success: Switched to 'Hello Elementor' theme.
Success: Installed 1 of 1 themes.
type	value
INFO	Themes that use the tag accessibility-ready will need to undergo an accessibility review. See https://make.wordpress.org/themes/handbook/review/accessibility/
INFO	Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs. The domain found is hello-elementor.
RECOMMENDED	No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
RECOMMENDED	No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
RECOMMENDED	This theme contains no sidebars/widget areas. See Widgets API
✔ Ran `bash hello-elementor-config/theme-check.sh` in 'cli'. (in 2s 15ms)

@Ntnelbaba
Ntnelbaba merged commit 601cbee into main Sep 16, 2026
26 checks passed
@Ntnelbaba
Ntnelbaba deleted the TMZ-1083-fix-conversion-banner-layout branch September 16, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants