Fix Cypress clicking a hidden From user files button. - #327
Merged
Merged
Conversation
The user file picker spec used contains().first(), which matched a button inside a collapsed dashboard row (display:none) instead of the add-component modal. Give the modal buttons stable ids and click the visible one. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Luigi Pellecchia <pellecchia.luigi@gmail.com>
pellecchialuigi
force-pushed
the
fix/user-file-select-hidden-button
branch
from
September 29, 2026 09:17
b3d3ad1 to
ac1d910
Compare
pellecchialuigi
marked this pull request as ready for review
September 29, 2026 10:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user file picker spec used contains().first(), which matched a button inside a collapsed dashboard row (display:none) instead of the add-component modal. Give the modal buttons stable ids and click the visible one.