Windows host: bat spawn, dialogs, and BEAM restart - #6
Merged
Conversation
Packaged host-first needs CreateProcess via cmd.exe for Mix .bat scripts, Win32 file/prompt dialogs for DesktopWebview.Dialog, and host-driven restart_beam so updates work without heart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.batscripts viacmd.exe /cand prefer.batwhen discoveringbeam/bin.dialog.choose_file/choose_directory(IFileOpenDialog) anddialog.prompt.restart_beam(process wait + backoff) andsystem.prepare_quitso packaged updates work withoutheart.scripts/build_windows.ps1to run undervcvarsviacmd.exe.Test plan
.\scripts\build_windows.ps1buildspriv/native/windows/DesktopWebView.exemix test test/e2e) on WindowsDesktopWebView.inispawnsbeam/bin/<app>.bat startrestart_beam=truerespawns;system.prepare_quitdoes not