Repository navigation
Avoid deprecated Android tag lookup for chart commands (PRO-4970) - #20
Merged
Merged
Conversation
✅ PR Checklist Validation PassedStatus: All 2 checklist items completed 🎉 This PR meets all requirements and is ready for review! This validation ensures all PR requirements are met before merging. |
🚧 Prerelease In ProgressBuilding and publishing prerelease version... This comment will be updated when publishing is complete. |
furkando
marked this pull request as ready for review
September 18, 2026 18:19
furkando
requested review from
EdiOanceaV2,
NGabuaeva,
felipe-lighter,
robertbarbu27,
rturtu and
sinantalhakosar
as code owners
September 18, 2026 18:19
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
🧹 Prerelease Cleanup CompleteAll prerelease versions for branch The following actions were performed:
This cleanup was performed automatically after PR merge. |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android KLine commands currently convert the native ref to a numeric tag. On Fabric,
UIManager.dispatchViewManagerCommandcallsfindShadowNodeByTag_DEPRECATED, the recursive lookup found in the reported baseline SIGSEGV. React Native 0.85.3 keeps its tree-lifetime fix disabled by default.Use React Native's
codegenNativeCommandswith the current host ref on Android, bypassing that lookup for all chart commands. Keep iOS's numeric command mapping and the existing command names/payloads. Detached refs are ignored. This removes the chart's exposure to the suspect lookup; it does not establish that every occurrence of the intermittent native crash has this cause.Linear ticket: PRO-4970
Validation
Author Checklist