Skip to content

fix(engines): tolerate unreadable pages when opening a document #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calebkish wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

fix(engines): tolerate unreadable pages when opening a document #784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions packages/engines/src/lib/pdfium/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,34 +370,35 @@ export class PdfiumNative implements IPdfiumExecutor {
? this.pdfiumModule.EPDF_GetPageSizeByIndexNormalized(docPtr, index, sizePtr)
: this.pdfiumModule.FPDF_GetPageSizeByIndexF(docPtr, index, sizePtr);

if (!result) {
// A single unreadable page (e.g. a malformed page dictionary PDFium
// cannot parse) must not fail the whole document. Fall back to a 0x0
// size for that page and keep going.
let size: { width: number; height: number };
if (result) {
size = {
width: this.pdfiumModule.pdfium.getValue(sizePtr, 'float'),
height: this.pdfiumModule.pdfium.getValue(sizePtr + 4, 'float'),
};
} else {
const lastError = this.pdfiumModule.FPDF_GetLastError();
this.logger.error(
this.logger.warn(
LOG_SOURCE,
LOG_CATEGORY,
`${normalizeRotation ? 'EPDF_GetPageSizeByIndexNormalized' : 'FPDF_GetPageSizeByIndexF'} failed with ${lastError}`,
`${normalizeRotation ? 'EPDF_GetPageSizeByIndexNormalized' : 'FPDF_GetPageSizeByIndexF'} failed for page ${index} with ${lastError}; using 0x0 fallback`,
);
this.memoryManager.free(sizePtr);
this.memoryManager.free(boxPtr);
this.pdfiumModule.FPDF_CloseDocument(docPtr);
this.memoryManager.free(filePtr);
this.logger.perf(LOG_SOURCE, LOG_CATEGORY, `OpenDocumentBuffer`, 'End', file.id);
return PdfTaskHelper.reject<PdfDocumentObject>({
code: lastError,
message: `${normalizeRotation ? 'EPDF_GetPageSizeByIndexNormalized' : 'FPDF_GetPageSizeByIndexF'} failed`,
});
size = { width: 0, height: 0 };
}

const rotation = this.pdfiumModule.EPDF_GetPageRotationByIndex(docPtr, index) as Rotation;
// EPDF_GetPageRotationByIndex returns -1 on error; clamp to 0 so the
// downstream `rotation & 3` math never treats a failed read as 270°.
const quarterTurns = this.pdfiumModule.EPDF_GetPageRotationByIndex(docPtr, index);
const rotation = (quarterTurns >= 1 && quarterTurns <= 3 ? quarterTurns : 0) as Rotation;
const objectNumber = this.pdfiumModule.EPDFDoc_GetPageObjectNumberByIndex(docPtr, index);
const boxes = this.readPageBoxes(docPtr, index, boxPtr);

const page = {
index,
size: {
width: this.pdfiumModule.pdfium.getValue(sizePtr, 'float'),
height: this.pdfiumModule.pdfium.getValue(sizePtr + 4, 'float'),
},
size,
rotation,
objectNumber,
boxes,
Expand Down