fix: toolbar overflow button aria-label and decorative icon svgs - #811
Open
marinaionel wants to merge 1 commit into
Open
marinaionel wants to merge 1 commit into
marinaionel wants to merge 1 commit into
Conversation
|
@marinaionel is attempting to deploy a commit to the CloudPDF Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #804.
The overflow-tabs button's
labelKeypointed attabs.overflowMenu, a translation key that was never actually defined anywhere in the locale catalog. The i18n plugin falls back to returning the raw key string when a translation is missing, so this button ended up with a garbage/non-meaningful accessible name instead of a real one. Switched it tomenu.moreOptions, the same label the analogousleft-action-menu:overflow-menubutton already uses for its "..." dots icon.Every generated toolbar icon component (and the custom-icon renderer in
icon.tsx) always rendered its<svg>withrole="img"andaria-label={title}, but no caller ever passes atitle, so every icon inside an already-labeled button ended up as an<svg role="img">with no accessible name at all, which axe-core flags directly. Nowrole/aria-hiddenare conditional ontitle: no title means the icon is marked decorative (aria-hidden, norole="img"), matching the icon's actual purpose inside a labeled button. If a caller ever does pass atitle, the icon still getsrole="img"+aria-labelas a standalone labeled image.Left the responsive-breakpoint behavior mentioned in the issue (#585) alone since this is only about the accessible-name/decorative-icon gap.