Skip to content

Add V2 gripper camera visuals and mounting reference frames - #100

Merged
kou merged 3 commits into
enactic:mainfrom
stevenaya:feat/v2-gripper-camera
Oct 28, 2026
Merged

kou merged 3 commits into
enactic:mainfrom
stevenaya:feat/v2-gripper-camera

Conversation

@stevenaya

@stevenaya stevenaya commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

The V2 gripper model lacks the camera geometry and viewing reference from the CAD assembly. Add the B0495 camera visual to ee_base_link and a massless camera_view_frame to the full robot and standalone gripper.

  • Reflect reference-frame position and orientation together for the left side.
  • Compose connection.origin relative to the selected mounting reference. Toggling emit changes the frame output while preserving the mounted component's pose.
  • Carry the reference poses through arm-tip folding, generate the grasp frame once, and regenerate the V2 example URDF.

Compatibility

connection.origin was an absolute override of the mounting reference's pose. It's now an offset relative to the mounting reference. All bundled presets use origin: null, so their generated URDFs don't change except the new camera_view_frame. Custom presets that set connection.origin with parent_reference_point need to be updated.

RViz comparison

Before After
Before After

Gripper base visual; colored axes show the new camera_view_frame. Separate RViz captures use identical placement and camera settings.

Validation: eight tests cover mirrored frames, standalone generation, folding, reference emission, grasp frame emission and mounting offsets, including the generated component and its composed world pose, and check camera_view_frame against the camera parts in the visual mesh. CI runs them with test/run.sh. All five V2 presets and both standalone grippers expand and pass check_urdf; the updated DAE loads successfully.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 09:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 09:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 10:52
@stevenaya
stevenaya force-pushed the feat/v2-gripper-camera branch from 0378d23 to eaed510 Compare October 23, 2026 10:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@stevenaya
stevenaya force-pushed the feat/v2-gripper-camera branch from eaed510 to fd4d46e Compare October 23, 2026 10:58
Copilot AI balanced review requested due to automatic review settings October 23, 2026 10:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@stevenaya
stevenaya force-pushed the feat/v2-gripper-camera branch from fd4d46e to 6042b5f Compare October 23, 2026 11:00
Copilot AI balanced review requested due to automatic review settings October 23, 2026 11:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@stevenaya
stevenaya force-pushed the feat/v2-gripper-camera branch from 6042b5f to 3285404 Compare October 27, 2026 05:03
Copilot AI balanced review requested due to automatic review settings October 27, 2026 05:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

kou and others added 2 commits October 28, 2026 12:01
* Add the license header.
* Change YAML files in a temporary share directory instead of
  replacing xacro's private load_yaml.
* Check camera_view_frame against the camera parts in the visual mesh
  instead of copied configuration values.
* Check grasp_frame emission for all combinations of the reference
  point's emit and the emit_grasp_frame argument.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add test/run.sh that builds out of the source tree and runs only our
pytest tests. ament_lint_common linters are excluded because we use
pre-commit for lint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 28, 2026 03:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@kou
kou deployed to release October 28, 2026 03:05 — with GitHub Actions Active
@kou

kou commented Oct 28, 2026

Copy link
Copy Markdown
Contributor
100_before 100_after

@kou
kou merged commit 22800fe into enactic:main Oct 28, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
release — b070a4ca Deployed Oct 28, 2026 by kou via Publish #244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants