ci: stop nightly schedule for the -pc e2e workflow - #2
Open
polylane[bot] wants to merge 1 commit into
Open
polylane[bot] wants to merge 1 commit into
polylane[bot] wants to merge 1 commit into
Conversation
Author
|
I wasn't able to finish working on this. Please try again in a little while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: n8n fork 'Test: E2E on -pc image' failed 3 consecutive nights — all shards die on 'Load n8n image from cache'
The endformdev/n8n fork's scheduled "Test: E2E on -pc image" workflow has failed every night since the fork was created (09-11 through 09-13): the image the prepare job reports as cached never actually exists in the fork's cache namespace, so all 16 E2E shards fail at "Load n8n image from cache" and the nightly is red every day with no one notified. Merging this removes the nightly schedule from that workflow, stopping the daily red CI noise on an unmaintained fork; the workflow remains runnable on demand through manual dispatch.
flowchart LR S["schedule 02:00Z (removed)"] -->|no longer starts| W["Test: E2E on -pc image"] W --> P["prepare-docker: lookup-only cache hit, build skipped"] P -->|no tarball saved| SH["16 shards: restore cache miss"] SH -->|rebuild fallback| B["pnpm build:docker fails"] B -->|no images| F["all shards red, no notification"] M["workflow_dispatch (kept)"] -->|manual only| WWhat caused this
Affected:
int_01ace0dc7001iivrvgsb7n32· severity lowWhat changed
.github/workflows/test-e2e-pc-nightly.yml: removed theschedule: 0 2 * * *trigger, keepingworkflow_dispatchwith its existing inputs.Why it's safe
Validation
.github/workflows/test-e2e-pc-nightly.ymlYAML validated with node:on:block contains onlyworkflow_dispatch,scheduleabsent, no tabs.Root cause and scoping notes
Root cause
The fork's nightly "Test: E2E on -pc image" workflow failed 3 consecutive nights (runs 34573341598, 34679782187, 34745119763). Job-level logs show the mechanism: the prepare-docker job's
lookup-onlycache check printed "Cache hit for: n8n-docker-image-v2-pc-6a1ad265..." and skipped the build (job completed in 8s), while every shard's restore then printed "Cache not found for input keys: n8n-docker-image-v2-pc-6a1ad265..." and fell back to a rebuild that died atpnpm build:docker([ELIFECYCLE] Command failed with exit code 1). The fork's cache namespace holds 223 keys, none of them a docker-image key, so the image has never been saved on the fork. The "Notify Cats" job also fails on the missingQBOT_SLACK_TOKENsecret, so the nightly is red with no notification. The fork is unmaintained (created 08-21, all activity that same day, 0 open PRs/issues, head 6a1ad26 from 09-10 vs upstream 4169b55). Removing thescheduletrigger is the fix: it stops the red nightly at the producer (the fork's own schedule), keeps the workflow available for manual runs, and requires no secrets or infrastructure. Upstream n8n-io/n8n still runs its own equivalent nightly on its own cache, which this change does not affect.Causal chain
Detection outcome
The fingerprinted signal is the scheduled workflow run of "Test: E2E on -pc image" on endformdev/n8n, conclusion
failure(runs 34573341598, 34679782187, 34745119763, nightly 02:00Z). With thescheduletrigger removed, the workflow no longer starts itself nightly, so no new run is created and the recurring failure stops. The underlying cache-handoff break (lookup-only hit vs restore miss, no docker-image key in the fork's 223-key cache namespace) remains, but it can only surface when a person manually dispatches the workflow, at which point it is a visible, actionable failure instead of silent nightly noise.Fix chosen
Chosen: cause (removes the mechanism that produces the failure): Remove the schedule trigger from test-e2e-pc-nightly.yml so the workflow no longer starts itself nightly; keep manual dispatch.
Considered and not chosen:
Outcome after fix
pnpm build:docker; the notify job fails on the missing Slack secret; the run ends red with nothing notified. This repeats every night.1 file changed (+0/-2)
.github/workflows/test-e2e-pc-nightly.yml: modified, +0/-2Repository conventions present in the repository: AGENTS.md, CLAUDE.md, .agents/skills/AGENTS.md, .github/CLAUDE.md, packages/@n8n/agents/AGENTS.md, packages/@n8n/ai-utilities/AGENTS.md, packages/@n8n/ai-workflow-builder.ee/AGENTS.md, packages/@n8n/ai-workflow-builder.ee/CLAUDE.md, packages/@n8n/db/AGENTS.md, packages/@n8n/engine/AGENTS.md, packages/@n8n/instance-ai/CLAUDE.md, packages/cli/AGENTS.md, packages/frontend/AGENTS.md, packages/frontend/CLAUDE.md, packages/nodes-base/AGENTS.md, packages/nodes-base/CLAUDE.md, packages/testing/janitor/CLAUDE.md, packages/testing/playwright/AGENTS.md, packages/testing/playwright/CLAUDE.md, scripts/instance-seeding/AGENTS.md, .agents/skills (community-pr-readiness-check, content-design, conventions, create-community-node-lint-rule, create-instance-ai-eval, create-issue, create-pr, create-skill, db-migrations, experiments, gh-stack, human-like-code-review, +10 more).
Repository lint:
pnpm lint(declared in AGENTS.md) could not run in the sandbox because its tool is not installed there; run it before merging.Generated by Polylane.