feat: endform integration - #3
Closed
augustoccesar wants to merge 23 commits into
Closed
augustoccesar wants to merge 23 commits into
augustoccesar wants to merge 23 commits into
Conversation
The CI control failed with "Cannot POST /rest/e2e/reset". The favicon check allowed setup to start before routes were ready. Change to use the readiness endpoint to wait for initialization.
The Endform trace showed frontend startup progressing after the 10-second navigation timeout. Increase only remote navigation to 30 seconds to test whether startup completes. Keep control timing and retries unchanged.
Both import tests failed because their JSON files were missing on remote runners. Include the workflows directory so runtime file reads can find the fixtures.
Both runners passed all five workflow entry-point tests. Add the existing credential CRUD spec for 19 tests total.
Both runners passed all 19 tests with serial execution. Raise the Endform concurrency limit from one to two.
All 19 tests passed with two concurrent Endform tests. Raise the limit to four to check parallel execution
Both runners passed all 19 tests at Endform concurrency four. Add nine existing tests for node search and canvas actions.
Both runners passed all 28 tests. Add seven tests for parameter inputs and field assignments.
Both runners passed all 35 tests. Add nine active tests for manual, webhook, and partial execution.
Both runners passed all 44 active tests. Add eight tests for API authentication and separate user sessions.
The session test exceeded 60 seconds on Endform. Its five page loads took about 50 seconds in total. All role assertions completed without errors in the trace. Raise the remote test budget to 90 seconds.
Both runners passed all 52 active tests. Increase Playwright from one worker to four. Keep Endform concurrency and the test set unchanged.
Three Playwright tests exceeded the 10-second navigation limit with four workers. Endform passed with a 30-second limit. Set a 30-second navigation limit for both experiment runners.
URL predicate handlers make Playwright intercept every request. Replace the health and version predicates with URL patterns. Keep their path matching and mocked responses unchanged.
The session trace still records 1,407 request continuations. A catch-all handler adds trace headers to browser requests. Remove that handler only in the Endform experiment. Keep targeted mocks and Playwright traces. Use the next run to measure its cost.
The trace confirms catch-all routing was removed. Request continuations fell from 1,407 to zero. Suite duration changed only from 8.2 to 8.1 minutes. Remove the diagnostic override. Restore normal tracing because no material speed gain was shown.
Page-load traces show delays beyond the main asset transfers. Disable video recording for both experiment runners. Keep traces, screenshots, tests, concurrency and timeouts unchanged. Use the next run to measure recording overhead. Preserve video recording by default outside the experiment.
Disabling video showed no Endform runtime improvement. Remove the experimental switch and restore recording. Preserve debugging evidence while investigating page-load delays.
Capture host and process resource usage during the test step. Record the backend listener PID to identify n8n usage. Preserve measurements with the existing run artifacts. Keep concurrency at four to establish a scaling baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.