ci: Remove Discord Notification workflow#2515
Merged
Merged
Conversation
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/ci-remove-discord-notification-workflow/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This is supposed to post on our Discord whenever a PR is merged. It used to run on the `pull_request` event, which only worked when PRs from our own team were merged: useless for highlighting community merges. Then I changed it to the `pull_request_target` event, which doesn't work at all. Just remove it. I deleted the channel on the other end. Resolves #1089
wjt
force-pushed
the
wjt/ci-remove-discord-notification-workflow
branch
from
7c5df90 to
1421459
Compare
Member
Author
|
I'm merging this without review because:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is supposed to post on our Discord whenever a PR is merged.
It used to run on the
pull_requestevent, which only worked when PRsfrom our own team were merged: useless for highlighting community
merges.
Then I changed it to the
pull_request_targetevent, which doesn't workat all.
Just remove it. I deleted the channel on the other end.
Resolves #1089