Skip to content

Fix/doge balance not showing - #820

Open
olgakup wants to merge 2 commits into
developfrom
fix/doge-balance-not-showing
Open

olgakup wants to merge 2 commits into
developfrom
fix/doge-balance-not-showing

Conversation

@olgakup

@olgakup olgakup commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Seems like node response was changed, balance.unconfirmedBalance is no longer defined string

Summary by CodeRabbit

  • Bug Fixes
    • Bitcoin balances now display correctly when the unconfirmed balance is missing or empty, using zero for that portion of the total.
    • Balance retrieval continues to return zero when an error occurs, while preserving the existing fallback for API-provided error messages.

@olgakup olgakup added the bug Something isn't working label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

💼 Build Files
chrome: enkrypt-chrome-a925d7ce.zip
firefox: enkrypt-firefox-a925d7ce.zip

💉 Virus total analysis
chrome: a925d7ce
firefox: a925d7ce

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: enkryptcom/enKrypt/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 330ea781-deab-4373-b5b1-fdfa2bad5f71
📥 Commits

Reviewing files that changed from the base of the PR and between fa17fe2 and a925d7c.

📒 Files selected for processing (1)
  • packages/extension/src/providers/bitcoin/libs/api-ss.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


Walkthrough

getBalance now handles a missing or empty unconfirmed balance as '0'. It logs caught errors before returning '0' and retains the existing API-message fallback.

Changes

Bitcoin balance fallback

Layer / File(s) Summary
Balance handling and error fallback
packages/extension/src/providers/bitcoin/libs/api-ss.ts
getBalance treats a missing or empty unconfirmedBalance as '0' and logs caught errors before returning '0'. The existing API-message fallback remains. The combined balance is calculated twice, with the first result stored in an unused local.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to a925d

The reviewed change addresses the reported missing-balance case. No actionable merge-blocking risk remains in the supplied review context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: fixing the DOGE balance display issue caused by the changed node response.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants