Remove F401 (unused import) ignores, fix all violations - #943
Open
Mubashir78 wants to merge 1 commit into
Open
Conversation
- Remove 12 unused imports across the codebase - Remove F401 from all per-file-ignores in pyproject.toml - Drop unused per-file-ignores entries for files where only F401 was ignored Part of enthought#643
junkmd
requested changes
Jul 30, 2026
junkmd
left a comment
junkmd
left a comment
Collaborator
There was a problem hiding this comment.
I've returned to contributing to open source.
Sorry for the delay, but I'll review your PR now.
| if self.enabled: | ||
| return | ||
| # first we have to be able to import numpy | ||
| import numpy |
Collaborator
There was a problem hiding this comment.
As noted in the comment above, we need to import numpy here to cache it in the Python import system.
By adding # noqa: F401 only to this line, you can remove the setting from pyproject.toml while keeping the import.
| import os | ||
| import sys | ||
|
|
||
| import sphinx_rtd_theme |
Collaborator
There was a problem hiding this comment.
This might have been necessary for Sphinx.
Please check if the documentation can still be built even if this is removed.
| import glob | ||
| from distutils.core import setup | ||
|
|
||
| import py2exe |
Collaborator
There was a problem hiding this comment.
Integration between this project and py2exe might already be broken, but I'd like to keep it as it is for now.
Please also add # noqa: F401 to this line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #643
per-file-ignoresentries in pyproject.toml