Repository navigation
Harden command failure - #18
Open
marcepartment wants to merge 1 commit into
Open
marcepartment wants to merge 1 commit into
marcepartment wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The shutdown path mutates stopped environments during dry runs, and the documented removal command fails for running containers.
3 open findings
What changed in this PR
Hardens forced volume restores by removing stopped/orphaned containers and reporting removal failures clearly.
Changes:
- Tear down all environment containers before restoration.
- Abort safely when volume removal fails and report holders.
- Document behavior and troubleshooting.
| File | Description |
|---|---|
utils/backup.sh |
Strengthens container teardown and volume-removal handling. |
docs/backup-restore.md |
Documents failure recovery. |
CHANGELOG.md |
Records restore fixes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+791
to
+793
| if [[ -n "${env_containers}" ]]; then | ||
| logMessage INFO "Stopping environment..." | ||
| "${ROLL_DIR}/bin/roll" env down || true | ||
| "${ROLL_DIR}/bin/roll" env down --remove-orphans || true |
| if [[ -n "$holders" ]]; then | ||
| logMessage ERROR "Containers still holding it (running or stopped): $holders" | ||
| fi | ||
| logMessage ERROR "Remove them first - 'roll env down' for this environment's containers, 'docker rm <name>' for any other - then rerun the restore." |
Comment on lines
+330
to
+332
| # Remove the container by the name the error printed, then retry | ||
| docker rm <name> | ||
| roll restore --force |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.