Skip to content

Styleguide/actu2026 search page - #869

Open
xentenza wants to merge 9 commits into
devfrom
styleguide/actu2026-search-page
Open

Styleguide/actu2026 search page#869
xentenza wants to merge 9 commits into
devfrom
styleguide/actu2026-search-page

Conversation

@xentenza

@xentenza xentenza commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • New search results page for News 2006
  • New "Search & Filter" organism
  • Rewritten "Select" Atom with variables

@xentenza
Search results for News 2026
f9bf6a5 
- New search results page
- Rewritten select types with variables
@xentenza
Search news title and pagination
89040e1 
added title and pagination to News Search
@xentenza
Select multiple
8cdd5af 
- Added variables to the "Select multiple" Atom
- Updated "Search & Filter" organisms
@github-actions

github-actions Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

  1 files    1 suites   0s ⏱️
328 tests 279 ✅ 0 💤  0 ❌ 49 🔥
328 runs  230 ✅ 0 💤 49 ❌ 49 🔥

For more details on these errors, see this check.

Results for commit f029681.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

🔎 Download the Backstop report for this pull request (link valid for 90 days):

@xentenza
label and updated search & filter organisms
dad952f 
- New conditional label for filters
- Updated search & filter for news
- Updated placeholder
@xentenza
Update search-and-filter-news.twig
82a7b72 
- Swap label "Unity" to "Entity"
- Updated placeholders
williambelle
williambelle reviewed Oct 1, 2026
View reviewed changes
Comment thread assets/components/molecules/filters/filters-search.twig Outdated
Comment thread assets/components/atoms/select/select-date.twig Outdated
Comment thread assets/components/organisms/search-and-filter/search-and-filter.twig Outdated
Comment thread assets/components/atoms/select/select-multiple.twig Outdated
Comment thread assets/components/atoms/select/select-date.twig
{% if label %} <label>{{~ label}}</label> {% else %} <label class="sr-only">Select date</label> {% endif %}
<button class="btn btn-secondary dropdown-toggle" type="button" id="dropdownMenuButton" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">Date</button>
<div class="dropdown-menu" aria-labelledby="dropdownMenuButton">
{% include '@molecules/datepicker/datepicker.twig' %}

@williambelle williambelle Oct 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Inclure une molécule à l'intérieur d'un atome contrevient à la conception atomique.

@xentenza xentenza Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vois que Datepicker n'est composé d'aucun atome. Ne faudrait-il pas le déplacer sous Atoms?

@williambelle williambelle Oct 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense qu'on peut le déplacer dans Atoms.

L'ajout de JavaScript ne le disqualifie pas. Il a le même profil que dropdown, collapse ou popover.

Rien dans l'historique ne justifie pourquoi le datepicker est considéré comme une « molécule ».

Comment thread assets/components/pages/news-search-2026/news-search-2026.twig Outdated
Comment thread assets/components/organisms/search-and-filter/search-and-filter.scss
Comment thread assets/components/organisms/search-and-filter/search-and-filter.yml
- name: events
title: Search & Filters Memento
- name: news
title: Search & Filters News

@williambelle williambelle Oct 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu peux compléter :

elements/reader/reader.scss

Lines 44 to 56 in ef590ec

/* Dropdown and multi select needs `overflow: visible` to allow it to
escape its container. */
.tlbx-item-preview.tlbx-element-contact,
.tlbx-item-preview.tlbx-element-dropdown,
.tlbx-item-preview.tlbx-element-nav-lang,
.tlbx-item-preview.tlbx-element-nav-user,
.tlbx-item-preview.tlbx-element-tag-input,
.tlbx-item-preview.tlbx-element-select-multiple,
.tlbx-item-preview.tlbx-element-breadcrumb-tagged,
.tlbx-item-preview.tlbx-element-breadcrumb-dropdown,
.tlbx-item-preview.tlbx-element-header-light-submenu {
overflow: visible;
}

pour éviter d'avoir les select derrière le code :

Image

@xentenza xentenza Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai tenté plusieurs solutions, je n'y arrive pas. @williambelle, peux-tu m'aider? Merci

@williambelle williambelle Oct 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai ajouté les 3 lignes.

Comment thread assets/components/organisms/search-and-filter/search-and-filter-events.twig Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williambelle williambelle williambelle left review comments
@lvenries lvenries Awaiting requested review from lvenries

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xentenza @williambelle