Skip to content

Link the upstream issues tracking each documented workaround - #16

Merged
sbfnk merged 1 commit into
mainfrom
link-upstream-issues
Oct 21, 2026
Merged

sbfnk merged 1 commit into
mainfrom
link-upstream-issues

Conversation

@sbfnk-bot

@sbfnk-bot sbfnk-bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Four behaviours in ForecastBaselines.jl are worked around or warned about in this package: the inverted ETS error-type strings, INARCH forecasts evaluating every harmonic at the fundamental frequency, ARMA mean parameters starting at zero, and STL's effective minimum series length. Each was reported upstream, so the roxygen and the one internal comment that describe them now link the issue that tracks each one.

Nothing changes at run time. A reader meeting one of these caveats can now check whether it still holds, and the workarounds can be removed once the upstream issues close.

Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.26%. Comparing base (d391e27) to head (975436d).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   66.97%   68.26%   +1.29%     
==========================================
  Files           8        8              
  Lines         327      334       +7     
==========================================
+ Hits          219      228       +9     
+ Misses        108      106       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbfnk-bot
sbfnk-bot marked this pull request as ready for review October 21, 2026 13:43
@sbfnk-bot
sbfnk-bot requested a review from sbfnk October 21, 2026 13:43
@sbfnk
sbfnk merged commit 8df217d into main Oct 21, 2026
9 checks passed
@sbfnk
sbfnk deleted the link-upstream-issues branch October 21, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants