Repository navigation
Finish the upstream issue links and drop a word from the INARCH warning - #17
Merged
Merged
Conversation
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 68.26% 68.16% -0.10%
==========================================
Files 8 8
Lines 334 333 -1
==========================================
- Hits 228 227 -1
Misses 106 106 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
sbfnk
approved these changes
Oct 21, 2026
sbfnk-bot
marked this pull request as ready for review
October 21, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vignette described the ARMA zero-start and the STL cycle requirement without pointing at the upstream issues that track them, while the INARCH bullet already did. Both now link their issue, so every caveat in the vignette says where it is tracked.
The INARCH warning, its test and the NEWS entry described the limitation as seasonality that is "not carried into the forecasts". They now say the forecasts do not reflect the estimated seasonality, which says the same thing in words the house style allows. 0.2.0 is unreleased, so the NEWS entry is still a draft.