Repository navigation
Review changes for #205, removes deprecated components - #206
Merged
Merged
Conversation
- Remove overly specific px measurement. These details can drift
we have this now!!
Over-specced. We have no plans to use this prop.
`ScrollArea` & `ScrollBar`, `ListOrGridViewToggle`, `Drawer` (never used, doesn't have a docs page even)
Shrinks99
commented
Oct 27, 2026
matthewmr-eqty
previously approved these changes
Oct 27, 2026
matthewmr-eqty
left a comment
matthewmr-eqty
left a comment
Contributor
There was a problem hiding this comment.
Approving. A few small asks inline.
matthewmr-eqty
dismissed
their stale review
October 27, 2026 19:22
Holding my approval until we settle onHighlightEnd (see inline). Everything else looks good.
This reverts commit f93507a.
Shrinks99
changed the title
Co-authored-by: matthewmr-eqty <matthew.rhodes@eqtylab.io>
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics> Co-authored-by: matthewmr-eqty <matthew.rhodes@eqtylab.io>
matthewmr-eqty
approved these changes
Oct 27, 2026
matthewmr-eqty
left a comment
matthewmr-eqty
left a comment
Contributor
There was a problem hiding this comment.
Thanks for keeping onHighlightEnd. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Because this previously required a major version bump to v5, I've also gone ahead and removed our deprecated components that are unused across Guardian and Explorer.
ScrollArea&ScrollbarDrawer(never used, doesn't even have a docs page)ListOrGridViewToggle- Replaced bySegmentedControls