Repository navigation
feat(ui): release 5.0.2 with a Retry row in NavSwitcher after a failed list - #209
Merged
Merged
Conversation
…d list
Need: people whose switcher list failed to load should see that it failed and be able to retry from the list.
Problem: NavSwitcher had no error state, so a failed list read looked the same as an empty one, and Studio carried its own copy with Retry that #536 deletes.
Solution: NavSwitcher takes error, retrying and onRetry (error needs onRetry). The list shows "Couldn't load {collection}." with a Retry row above any options, keeps the list open through Retry, reads "Retrying..." while a retry runs, and announces the failure, the retry and its result. A switcher with one option stays a switcher, as Studio already has it. Spinner renders spans so it can sit inside an option.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports Studio's switcher Retry (eqtylab/guardian#533) into
NavSwitcherand releases@eqtylab/equality5.0.2, so eqtylab/guardian#536 can swap Studio's copy for this one without losing it.error, the list shows "Couldn't load {collection}." and a Retry row above any options it already has. A search that matches nothing still says "No {collection} found".onRetryand keeps the list open. Withretryingthe row reads "Retrying..." and isaria-disabled. The types requireonRetrywitherror.<form>, Radix's hidden native select can pick Retry; that's ignored while closed, which stops a refetch loop.Spinnerrenders spans, so it is valid inside an option. It looks the same.Testing
pnpm format:check,pnpm lint,pnpm test(162 passed) andpnpm buildpass.NavSwitcher, the switcher specs give the same result as on 5.0.1: 154 passed. The five that fail on both are styling differences between Studio's switcher and Equality's, and Studio's loading row. #536 deals with them.🤖 Generated with Claude Code