Repository navigation
ci: leave scripts/ out of the Veracode scan - #113
Merged
Merged
Conversation
scripts/ is maintainer tooling (docs archiving, release checks). It is in the sdist's source tree but never installed or run by a build or by eqty_sdk. With veracode-severity now enforced, its two Very High CWE-78 findings in scripts/archive_version.py fail the main scan; both are subprocess.run calls with argument lists and no shell.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
scriptstoexclude-dirsin both Code Scanning jobs (PR andmain), soscripts/is no longer part of the Veracode source upload.Why:
vbuild-scan-actionnow enforces Veracode's pipeline severities by default (eqtylab/vbuild-scan-action#6). Since then themainscan fails on two Very High CWE-78 "OS Command Injection" findings (run):scripts/archive_version.py:143,subprocess.run(["git", "show", f"{GH_PAGES}:{rel}"], …)scripts/archive_version.py:210,subprocess.run(["git", "archive", tag], …)Both pass an argument list with no shell, so there is no shell to inject into.
scripts/is maintainer tooling (docs archiving, release and link checks):maturin sdistfrommainhas all 15 files)scripts/is installed or run, by a build or byeqty_sdkEffect on the upload: I ran the action's zip packaging on this branch with the old and new
exclude-dirs. The upload goes from 523 to 507 entries: the 16 underscripts/are gone, andeqty_sdk/andsrc/are unchanged. All nine findings from the last scan were inscripts/: the two Very High above, plus seven Medium (CWE-73) inarchive_version.py,manifest_diff.py,verify_manifest_roundtrip.pyandcheck_old_links.py.exclude-dirsalso becomes--skip-dirsfor Trivy's vulnerability and license scans, so Trivy skipsscripts/too. Nothing is lost on vulnerabilities:scripts/has no dependency manifests (no requirements, lock orpyprojectfiles). Only the license scan of its 15 script files goes.No CHANGELOG entry: this changes CI only, not the SDK.