Repository navigation
fix(convert): anchor /dist in the site .gitignore - #11
Merged
Merged
Conversation
…heme and plugin scripts are tracked A bare dist line also ignored wp-content/themes/<theme>/dist/, wp-includes/js/dist/ and plugin builds under public/. CLI deploys upload from disk, so previews worked, but a Git build of main had none of those files and the theme scripts 404'd in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The site template's
.gitignorehad a baredist, meant for Astro's build output. It also ignored everypublic/**/dist/folder, where WordPress themes and plugins keep their built scripts (wp-content/themes/<theme>/dist/,wp-includes/js/dist/, plugindist/builds). It is now anchored as/dist.Why it matters:
vercel deployfrom the CLI uploads files from disk, so previews had those scripts, but a Git-connected build ofmaindid not. On the angrybirds.com conversion, 75 files were missing in production (the theme'sfrontend.js, GSAP, WordPress hooks and i18n, theme fonts and favicons), so the theme scripts returned 404 there. The site fix is https://github.com/ethanplusai/angrybirds-com/pull/4.skills/convert-site/templates/site/.gitignore:/dist, with a comment on why it is anchored.test/convert/init-site.test.mjs: a scaffolded site trackspublic/wp-content/themes/x/dist/app.jsand still ignores the rootdist/.skills/convert-site/references/hosting-vercel.md: one line on the difference between CLI and Git builds.This commit was pushed to #6's branch after #6 had been squash-merged, so it never reached
main; this PR carries it on its own.Checks
npm test: 845 tests pass.npm run hygiene: OK.🤖 Generated with Claude Code