Repository navigation
Fixes: server-only forms, doubled-slash CSS URLs, CDATA sitemaps - #15
Merged
Merged
Conversation
No CLI flag or decision id; the agent decides how to handle a server-only form, and the gate only checks that a form kept but switched off sends nowhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three general fixes. None adds per-site configuration.
Forms a static site cannot serve. Login, account, cart and checkout forms need a server, and the forms gate's only option was to rewire them to the form endpoint, which would send passwords or payment details to a form service.
references/forms.mdnow states the principle (never rewire one) and leaves the handling to the agent: switch it off, link out, or embed. A form kept but switched off is listed in an optionalinert-forms.jsonas{ path, form, reason }. The gate checks that it keeps live's fields and method and that its action sends nowhere (none,#orjavascript:), then counts it as skipped. There is no new flag.Doubled-slash same-origin CSS URLs. A live stylesheet URL such as
https://example.com//wp-content/font.ttfwas pruned to//wp-content/..., which the browser reads as a link to another host, so fonts and images went missing.css-prune.mjsnow collapses the leading slashes.CDATA sitemap locations. The sitemaps gate read
<loc><![CDATA[...]]></loc>as part of the URL, so every entry in such a sitemap failed. It now strips the wrapper.Verification
npm testpasses, including the newtest/gates/forms-inert.test.mjs. CI runs on Node 22 and 24.🤖 Generated with Claude Code