Repository navigation
fix(convert): review-serve listens on loopback only - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13.
review-serve.mjscalledserver.listen(port)with no host, so it listened on every network interface while printinglocalhost. Anyone on the same network could open the site under review. It now binds to127.0.0.1, like the kit's other servers.Verification
127.0.0.1and refuses the machine's network address. It failed before the fix and passes after it. It skips on a machine with no non-loopback IPv4 address.npm test: 846 passed, 0 failed.🤖 Generated with Claude Code